forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SegWit wallet support #5
Open
adamjonas
wants to merge
12
commits into
bitcoin-fresheyes-master-11403
Choose a base branch
from
sipa-fresheyes-201709_segwitwallet2-11403
base: bitcoin-fresheyes-master-11403
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SegWit wallet support #5
adamjonas
wants to merge
12
commits into
bitcoin-fresheyes-master-11403
from
sipa-fresheyes-201709_segwitwallet2-11403
Commits on Jan 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0c8ea63 - Browse repository at this point
Copy the full SHA 0c8ea63View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbe1974 - Browse repository at this point
Copy the full SHA cbe1974View commit details -
Configuration menu - View commit details
-
Copy full SHA for 985c795 - Browse repository at this point
Copy the full SHA 985c795View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30a27dc - Browse repository at this point
Copy the full SHA 30a27dcView commit details -
Extend validateaddress information for P2SH-embedded witness
This adds new fields 'pubkeys' and 'embedded' to the RPC's output, and improves the documentation for previously added 'witness_version' and 'witness_program' fields.
Configuration menu - View commit details
-
Copy full SHA for 3eaa003 - Browse repository at this point
Copy the full SHA 3eaa003View commit details
Commits on Jan 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 37c03d3 - Browse repository at this point
Copy the full SHA 37c03d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf2c0b6 - Browse repository at this point
Copy the full SHA cf2c0b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57273f2 - Browse repository at this point
Copy the full SHA 57273f2View commit details -
Implicitly know about P2WPKH redeemscripts
Make CKeyStore automatically known about the redeemscripts necessary for P2SH-P2WPKH (and due to the extra checks in IsMine, also P2WPKH) spending.
Configuration menu - View commit details
-
Copy full SHA for f37c64e - Browse repository at this point
Copy the full SHA f37c64eView commit details -
This introduces two command line flags (-addresstype and -changetype) which control the type of addresses/outputs created by the GUI and RPCs. Certain RPCs allow overriding these (`getnewaddress` and `getrawchangeaddress`). Supported types are "legacy" (P2PKH and P2SH-multisig), "p2sh-segwit" (P2SH-P2WPKH and P2SH-P2WSH-multisig), and "bech32" (P2WPKH and P2WSH-multisig). A few utility functions are added to the wallet to construct different address type and to add the necessary entries to the wallet file to be compatible with earlier versions (see `CWallet::LearnRelatedScripts`, `GetDestinationForKey`, `GetAllDestinationsForKey`, `CWallet::AddAndGetDestinationForScript`).
Configuration menu - View commit details
-
Copy full SHA for 940a219 - Browse repository at this point
Copy the full SHA 940a219View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ee54fd - Browse repository at this point
Copy the full SHA 7ee54fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b224a47 - Browse repository at this point
Copy the full SHA b224a47View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.