Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SegWit wallet support #5

Open
wants to merge 12 commits into
base: bitcoin-fresheyes-master-11403
Choose a base branch
from

Commits on Jan 3, 2018

  1. Configuration menu
    Copy the full SHA
    0c8ea63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cbe1974 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    985c795 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    30a27dc View commit details
    Browse the repository at this point in the history
  5. Extend validateaddress information for P2SH-embedded witness

    This adds new fields 'pubkeys' and 'embedded' to the RPC's output, and improves the
    documentation for previously added 'witness_version' and 'witness_program' fields.
    sipa committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    3eaa003 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2018

  1. Configuration menu
    Copy the full SHA
    37c03d3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf2c0b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    57273f2 View commit details
    Browse the repository at this point in the history
  4. Implicitly know about P2WPKH redeemscripts

    Make CKeyStore automatically known about the redeemscripts necessary for P2SH-P2WPKH
    (and due to the extra checks in IsMine, also P2WPKH) spending.
    sipa committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    f37c64e View commit details
    Browse the repository at this point in the history
  5. SegWit wallet support

    This introduces two command line flags (-addresstype and -changetype) which control
    the type of addresses/outputs created by the GUI and RPCs. Certain RPCs allow
    overriding these (`getnewaddress` and `getrawchangeaddress`). Supported types
    are "legacy" (P2PKH and P2SH-multisig), "p2sh-segwit" (P2SH-P2WPKH and P2SH-P2WSH-multisig),
    and "bech32" (P2WPKH and P2WSH-multisig).
    
    A few utility functions are added to the wallet to construct different address type
    and to add the necessary entries to the wallet file to be compatible with earlier
    versions (see `CWallet::LearnRelatedScripts`, `GetDestinationForKey`,
    `GetAllDestinationsForKey`, `CWallet::AddAndGetDestinationForScript`).
    sipa committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    940a219 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7ee54fd View commit details
    Browse the repository at this point in the history
  7. Add address_types test

    Improvements and cleanups by John Newbery
    sipa committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    b224a47 View commit details
    Browse the repository at this point in the history