Break glass keys #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkaplan
force-pushed
the
break-glass-keys
branch
from
2b77027 to
2727755
Compare
| // against the SSL leaf certificate. If this operation is successful, then | ||
| // we can trust the certificate, otherwise continue treating as invalid | ||
| // trust chain. | ||
| CFIndex leafCertIndex = certificateChainLen - 1; |
There was a problem hiding this comment.
This appears to assume the "break glass" certificate is used directly. What if it is used as a CA to endorse a chain of trust. Shouldn't we loop down the chain like we do below?
| NSSet<NSData *> *knownPins, | ||
| TSKSPKIHashCache *hashCache) | ||
| { | ||
| CFStringRef certificateSubject = SecCertificateCopySubjectSummary(certificate); |
There was a problem hiding this comment.
Pretty wasteful to extract certificateSubject in production just in case we need it for debugging. But I can respect that it was already there in the previous version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.