Skip to content

Comments

Add previous voice toggle functionality#3

Open
GruiaChiscop wants to merge 1 commit intoadamsamec:mainfrom
GruiaChiscop:newFeatures
Open

Add previous voice toggle functionality#3
GruiaChiscop wants to merge 1 commit intoadamsamec:mainfrom
GruiaChiscop:newFeatures

Conversation

@GruiaChiscop
Copy link

Introduces a script and supporting method to switch to the previous voice in the voice settings. Updates gesture descriptions and ensures proper index handling for both next and previous voice toggling. The voice toggle has also been added in the NVDA's input gestures dialog

Introduces a script and supporting method to switch to the previous voice in the voice settings. Updates gesture descriptions and ensures proper index handling for both next and previous voice toggling.
@adamsamec
Copy link
Owner

At this point, I don't plan to merge this PR mainly because of two reasons:

  1. You are introducing logic to the init.py file which should be instead placed into voiceToggle.py.
  2. You have removed the default gesture - NVDA + Alt + V. VoiceToggle should not expect user to need to define their own gesture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants