Update: Remove drawer dialog modal aria-expanded state (fixes #658) #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverfoster
approved these changes
May 13, 2025
Member
|
Is this not included in #663 already? |
Contributor
Author
Contributor
Author
|
Closing as fix included in #663 already. |
github-project-automation
bot
moved this from Needs Reviewing
to Recently Released
in adapt_framework: The TODO Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #658
Update
aria-expandedfrom Drawer<dialog>as this serves no purpose and it is not the intended use.When testing with a screen reader, the 'expanded' state wasn't announced so removing this doesn't have an impact on the reading however updating inline with accessibility best practice. See MDN note for reference below or refer to the issue description.