Skip to content

Fix: Harden execution condition typo (fixes #814) #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliverfoster merged 1 commit into from
Jan 7, 2026
Merged

Fix: Harden execution condition typo (fixes #814) #815

oliverfoster merged 1 commit into from
Jan 7, 2026

Conversation

@oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Jan 7, 2026 •
edited
Loading

fixes #814

Harden mistakenly had the opposite run condition.

Fix

  • Fixed the condition of execution by inverting !==

Testing

Please also test and approve adaptlearning/adapt-contrib-spoor#350

  • config.json:_fixes._harden = true
  • Must be built with grunt build or equivalent.
  • Check for require('core/js/adapt') in the console. It should not be accessible.

@oliverfoster oliverfoster self-assigned this Jan 7, 2026
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Jan 7, 2026
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

swashbuck
swashbuck approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 2922725 into master Jan 7, 2026
1 check passed
@oliverfoster oliverfoster deleted the issue/814 branch January 7, 2026 19:30
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jan 7, 2026
github-actions bot pushed a commit that referenced this pull request Jan 7, 2026
@semantic-release-bot
Chore(release): 6.72.3
a722aa1 
## [6.72.3](v6.72.2...v6.72.3) (2026-01-07)

### Fix

* Harden execution condition typo (fixes #814) (#815) ([2922725](2922725)), closes [#814](#814) [#815](#815)
@oliverfoster
Copy link
Member Author

oliverfoster commented Jan 7, 2026

🎉 This PR is included in version 6.72.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swashbuck swashbuck swashbuck approved these changes

@joe-replin joe-replin joe-replin approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels

bug released

Projects

adapt_framework: The TODO Board
Status: Recently Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect condition in core hardening

5 participants

@oliverfoster @swashbuck @joe-replin @cahirodoherty-learningpool