Skip to content

Fix: Logic for detecting removed elements (fixed #819) #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oliverfoster wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Logic for detecting removed elements (fixed #819) #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions js/DOMElementModifications.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,10 @@ export class DOMElementModifications extends Backbone.View {
const hasReAdded = (lastRemovedIndex !== -1 && lastAddedIndex !== -1 && lastRemovedIndex < lastAddedIndex);
// Element was moved, not added or removed
if (!isNew && hasReAdded) return ['changed'];
const isRemoved = (!isNew && lastRemovedIndex !== -1);
const events = _.uniq([
isNew && 'added',
isRemoved && 'removed',
eventNames[eventNames.length - 1]
].filter(Boolean));
return events;
Expand Down
Loading