Skip to content

Update: Update html target selector from element to class (fix #130) #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joe-allen-89 merged 3 commits into from
Aug 6, 2025
Merged

Update: Update html target selector from element to class (fix #130) #145

joe-allen-89 merged 3 commits into from
Aug 6, 2025

Conversation

@swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Jun 26, 2025

Fixes #130

Update

  • Updates html target selector from element to .html class

@swashbuck swashbuck self-assigned this Jun 26, 2025
@swashbuck swashbuck requested a review from guywillis June 26, 2025 16:51
@swashbuck swashbuck moved this from New to Needs Reviewing in adapt_framework: The TODO Board Jun 26, 2025
@cahirodoherty-learningpool
Copy link
Contributor

cahirodoherty-learningpool commented Jul 3, 2025

There is a Core (v6.60.13) dependency here, so package.json framework dependency needs bumped to v5.46.4

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

guywillis
guywillis approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit 20cf041 into master Aug 6, 2025
@joe-allen-89 joe-allen-89 deleted the issue/130 branch August 6, 2025 09:06
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Aug 6, 2025
github-actions bot pushed a commit that referenced this pull request Aug 6, 2025
@semantic-release-bot
Chore(release): 5.9.0 [skip ci]
9969cda 
# [5.9.0](v5.8.2...v5.9.0) (2025-08-06)

### Update

* Update html target selector from element to class (fixes #130) (#145) ([20cf041](20cf041)), closes [#130](#130) [#145](#145)
@github-actions
Copy link

github-actions bot commented Aug 6, 2025

🎉 This PR is included in version 5.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guywillis guywillis guywillis approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@swashbuck swashbuck

Labels

enhancement ready to release released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update html target selector from element to class

5 participants

@swashbuck @cahirodoherty-learningpool @guywillis @joe-allen-89