Skip to content

Conversation

@cahirodoherty-learningpool
Copy link
Contributor

Addresses #148

Fix

  • Escape key test needs to target body for Cypress to handle it

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Cypress end-to-end tests by changing how the Escape key is simulated. The tests were previously triggering keyboard events directly on drawer elements, but Cypress requires targeting the body element with the .type() command for proper keyboard event handling.

  • Replaced .trigger('keydown') calls with .type('{esc}') on the body element
  • Updated two test files to use the correct Cypress API for simulating keyboard input

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/e2e/pageResources.cy.js Updated ESC key test to target body element instead of drawer
test/e2e/menuResources.cy.js Updated ESC key test to target body element instead of drawer

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cahirodoherty-learningpool cahirodoherty-learningpool merged commit a7fb6fe into master Oct 21, 2025
1 check passed
@cahirodoherty-learningpool cahirodoherty-learningpool deleted the issue/148 branch October 21, 2025 11:31
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Oct 21, 2025
github-actions bot pushed a commit that referenced this pull request Oct 21, 2025
## [5.9.2](v5.9.1...v5.9.2) (2025-10-21)

### Fix

* Escape key test needs to target body for Cypress to handle it (#149) ([a7fb6fe](a7fb6fe)), closes [#149](#149)
@github-actions
Copy link

🎉 This PR is included in version 5.9.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants