-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.11.2 #2705
Release v0.11.2 #2705
Conversation
Snyk has created this PR to upgrade body-parser from 1.20.0 to 1.20.1. See this package in npm: https://www.npmjs.com/package/body-parser See this project in Snyk: https://app.snyk.io/org/cksachdev/project/52f6c7f9-9208-4ca6-8dba-2e0784a7c4e2?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade express from 4.18.1 to 4.18.2. See this package in npm: https://www.npmjs.com/package/express See this project in Snyk: https://app.snyk.io/org/cksachdev/project/52f6c7f9-9208-4ca6-8dba-2e0784a7c4e2?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @babel/preset-env from 7.19.3 to 7.19.4. See this package in npm: https://www.npmjs.com/package/@babel/preset-env See this project in Snyk: https://app.snyk.io/org/cksachdev/project/52f6c7f9-9208-4ca6-8dba-2e0784a7c4e2?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade traverse from 0.6.6 to 0.6.7. See this package in npm: https://www.npmjs.com/package/traverse See this project in Snyk: https://app.snyk.io/org/cksachdev/project/52f6c7f9-9208-4ca6-8dba-2e0784a7c4e2?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade @babel/core from 7.19.3 to 7.19.6. See this package in npm: https://www.npmjs.com/package/@babel/core See this project in Snyk: https://app.snyk.io/org/cksachdev/project/52f6c7f9-9208-4ca6-8dba-2e0784a7c4e2?utm_source=github&utm_medium=referral&page=upgrade-pr
Fixes #2693
#### Fixing domainsEnabled issue in Adapt Authoring If you are getting following error in console ``` (node:23152) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead. (Triggered by calling processImmediate on process.) (Use `node --trace-deprecation ...` to show where the warning was created) ``` Then follow the steps mentioned below: Steps: 1. Application.js 1. Modify connection options with domainsEnabled for connect-mongodb-session 2. Instead of requestDomain.enter use requestDomain.run(next) and comment next() 2. permissions.js inside policyChecker function 1. Line 497, update to 1. const user = app.usermanager.getCurrentUser() || JSON.parse(JSON.stringify(req.session.passport.user)); 3. Manually install 1. npm i connect-mongodb-session@2.4.1 2. npm i mongoose@5.8.13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pages aren't loading and getting 500 errors from any API call.
Most likely an issue caused by either the bump of the Node version or the mongodb major version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting 500 errors from any request made. Throws a Error: Failed to determine user's tenant!
in the console whenever this happens.
I imagine this is caused by the upgrade of mongodb from 3.7.3
to 4.10.0
.
I'm testing now reverting these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just google searched the error message and found this forum thread from 3 years ago https://community.adaptlearning.org/mod/forum/discuss.php?d=3811
I can confirm that the issue gets fixed if you run npm install mongoose@5.8.13
. This version of mongoose was specified in the package.json file so I'm not sure why it wasn't working in the first place. Any ideas @taylortom ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently running a production test, will let you know if we see any issues |
@@ -13,29 +13,29 @@ | |||
}, | |||
"main": "index", | |||
"engines": { | |||
"node": "12 || 14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using node versions higher than 18.15.0 will cause installation of certain plugins to fail, due to ZJONSSON/node-unzipper#271. (after uploading and unzipping, properties.schema will be mangled, causing JSON.parse to fail).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added your comment as an issue (#2735) for discussion with the dev team :)
This has been tested in a production environment, with no new issues reported. |
Issues
Case sensitive emails #2698_globals._extensions
form elements incorrectly rendered #2693_globals._extensions
missing from editor #2691Housekeeping
To be completed after all PRs merged