Skip to content

Date Formatting: Ensure consistent "full" format with comma after day name #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion scripts/utils/datetime.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
const locale = 'en-GB';
const timeOptions = { hour: '2-digit', minute: '2-digit', timeZone: 'UTC' };
const dateFullOptions = { dateStyle: 'full' };
const datePatternWithoutComma = /^(\w+) (\d+ \w+ \d+)$/;

/**
* Format date in full format.
Expand All @@ -9,7 +10,13 @@ const dateFullOptions = { dateStyle: 'full' };
* @returns {string} Formatted date
*/
export function formatDateFull(date) {
return date.toLocaleDateString(locale, dateFullOptions);
const formattedDate = date.toLocaleDateString(locale, dateFullOptions);
// insert comma after day name if not already present
const match = datePatternWithoutComma.exec(formattedDate);
if (match) {
return `${match[1]}, ${match[2]}`;
}
return formattedDate;
}

/**
Expand Down