Skip to content

fix: decode bitmaps off main thread in ImageElement #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: decode bitmaps off main thread in ImageElement #33

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86026a4
fix: decode bitmaps off main thread in ImageElement
Apr 9, 2025
719783a
Resolve merge conflicts in ImageElement.kt
Aug 15, 2025
63f807b
Merge branch 'adaptyteam:master' into fix-image-decoding-off-main-thread
frankjoshua Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions adapty-ui/src/main/java/com/adapty/ui/internal/ui/element/ImageElement.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@ import androidx.compose.foundation.layout.BoxWithConstraints
import androidx.compose.foundation.layout.fillMaxHeight
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.produceState
import androidx.compose.runtime.remember
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.ColorFilter
import androidx.compose.ui.graphics.ImageBitmap
import androidx.compose.ui.graphics.asImageBitmap
import androidx.compose.ui.platform.LocalContext
import com.adapty.internal.utils.InternalAdaptyApi
Expand All @@ -23,6 +26,8 @@ import com.adapty.ui.internal.ui.attributes.toComposeFill
import com.adapty.ui.internal.utils.EventCallback
import com.adapty.ui.internal.utils.getBitmap
import com.adapty.ui.internal.utils.getAsset
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext

@InternalAdaptyApi
public class ImageElement internal constructor(
Expand Down Expand Up @@ -55,14 +60,17 @@ public class ImageElement internal constructor(
}
val image = resolveAssets().getAsset<Asset.Image>(assetId)
BoxWithConstraints {
val imageBitmap = remember(constraints.maxWidth, constraints.maxHeight, image?.main?.source?.javaClass, isSystemInDarkTheme) {
image?.let {
getBitmap(context, image, constraints.maxWidth, constraints.maxHeight, if (aspectRatio == AspectRatio.FIT) ScaleType.FIT_MIN else ScaleType.FIT_MAX)
?.asImageBitmap()
val imageBitmapState by produceState<ImageBitmap?>(null, constraints.maxWidth, constraints.maxHeight, image?.main?.source?.javaClass, isSystemInDarkTheme) {
value = withContext(Dispatchers.Default) {
image?.let {
getBitmap(context, image, constraints.maxWidth, constraints.maxHeight,
if (aspectRatio == AspectRatio.FIT) ScaleType.FIT_MIN else ScaleType.FIT_MAX
)?.asImageBitmap()
}
}
}

if (imageBitmap == null) return@BoxWithConstraints
val imageBitmap = imageBitmapState ?: return@BoxWithConstraints

Image(
bitmap = imageBitmap,
Expand Down