Reload connection pool when connection with Postgres is lost #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeriaux
reviewed
Feb 3, 2020
cryptobioz
force-pushed
the
reload-pool-connection-lost
branch
from
0d5164c
to
03cdcf1
Compare
bmeriaux
reviewed
Feb 3, 2020
cryptobioz
force-pushed
the
reload-pool-connection-lost
branch
2 times, most recently
from
3c2874b
to
5a82265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the connection pool is created during the initialization, when the connection to the PostgreSQL server is lost, Addok is not able to setup a new connection pool. Thus, you must restart Addok to get your service back.
This PR intends to fix this behavior by checking if the connection is lost every time you request a connection from the pool. If it's the case, it will create a new pool and pick a connection from it.