Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TextLink): Add TextLink component #843

Merged
merged 49 commits into from
Jan 25, 2024
Merged

feat(TextLink): Add TextLink component #843

merged 49 commits into from
Jan 25, 2024

Conversation

kazaky
Copy link

@kazaky kazaky commented Dec 7, 2023 •
edited
Loading

📋 Changes

🤔 Context

✅ Checklist

  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • If it includes design changes, please ask for a review spark-design GitHub team.

📸 Screenshots

Screenshot 2023-12-11 at 5 02 36 PM Screenshot 2024-01-05 at 5 58 29 PM

🗒️ Other info

@kazaky kazaky added the Component Related to a component label Dec 7, 2023
@kazaky kazaky added this to the Q4 - Sprint 5 milestone Dec 7, 2023
@kazaky kazaky self-assigned this Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

🔣 PR title format

commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Add TextLink component"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

🔣 PR title format

commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Add TextLink component"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

🔣 PR title format

commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Add TextLink component"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$

@github-actions GitHub Actions
Copy link
Contributor

🔣 PR title format

commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Add TextLink component"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$

@github-actions GitHub Actions
Copy link
Contributor

🔣 PR title format

commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Add TextLink component"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$

@github-actions GitHub Actions
Copy link
Contributor

🔣 PR title format

commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Add TextLink component"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$

@github-actions GitHub Actions
Copy link
Contributor

🔣 PR title format

commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Add TextLink component"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$

@github-actions GitHub Actions
Copy link
Contributor

🔣 PR title format

commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "Add TextLink component"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$

@kazaky kazaky changed the title Add TextLink component feat(TextLink): Add TextLink component Dec 11, 2023
@kazaky kazaky marked this pull request as ready for review December 12, 2023 13:07
@kazaky kazaky requested review from soulcramer, SimonMarquis and a team as code owners December 12, 2023 13:07
@github-actions GitHub Actions
Copy link
Contributor

🚨 UI regression detected! Checkout the paparazzi-delta artifact.
If these changes are expected, you can either:

  • manually run the gradlew recordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

@kazaky
Copy link
Author

kazaky commented Dec 12, 2023

@spark-ui-bot paparazzi golden images

soulcramer
soulcramer previously approved these changes Jan 25, 2024
View reviewed changes
spark-screenshot-testing/build.gradle.kts Outdated Show resolved Hide resolved
@kazaky
Copy link
Author

kazaky commented Jan 25, 2024

@spark-ui-bot Paparazzi golden images

@kazaky kazaky enabled auto-merge January 25, 2024 09:18
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 25, 2024
View reviewed changes
catalog/src/main/res/values/strings.xml Fixed Show fixed Hide fixed
catalog/src/main/res/values/strings.xml Fixed Show fixed Hide fixed
catalog/src/main/res/values/strings.xml Fixed Show fixed Hide fixed
catalog/src/main/res/values/strings.xml Fixed Show fixed Hide fixed
SimonMarquis
SimonMarquis reviewed Jan 25, 2024
View reviewed changes
...otlin/com/adevinta/spark/catalog/configurator/samples/progressbar/ProgressbarConfigurator.kt Outdated Show resolved Hide resolved
catalog/src/main/kotlin/com/adevinta/spark/catalog/model/Components.kt Outdated Show resolved Hide resolved
catalog/src/main/res/drawable/icon_textlink.xml Outdated Show resolved Hide resolved
catalog/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
catalog/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
catalog/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
catalog/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
...ages/com.adevinta.spark.text_TextLinkScreenshot_testTextLinkButton_textlinkbutton_accent.png Outdated Show resolved Hide resolved
spark/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
@kazaky kazaky disabled auto-merge January 25, 2024 16:20
@kazaky kazaky enabled auto-merge January 25, 2024 17:19
@kazaky kazaky disabled auto-merge January 25, 2024 17:49
@kazaky kazaky merged commit ea2c67d into main Jan 25, 2024
5 checks passed
@kazaky kazaky deleted the TextLink branch January 25, 2024 17:49
SimonMarquis
SimonMarquis reviewed Jan 26, 2024
View reviewed changes
catalog/src/main/res/values/strings.xml
@@ -88,4 +90,9 @@
<string name="component_menu_issue">Report an issue</string>

<string name="icons_screen_search_helper">Search Spark Icon</string>
</resources>

<string name="spark_text_link_paragraph_example_"><annotation typography="body1" color="neutral">This is Adevinta </annotation><annotation typography="body1" color="main"><u><b>Privacy &amp; Policy</b></u></annotation><annotation typography="body1" color="neutral">also lots of extra information you maybe interested in or should I inform you about that extra information. you might be not knowing it</annotation></string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazaky I'm not sure why these have been renamed with trailing underscores 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a build error for duplicate res. I just renamed the String res and its fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonMarquis SimonMarquis SimonMarquis left review comments

@soulcramer soulcramer soulcramer left review comments

Assignees

@kazaky kazaky

Labels
Component Related to a component
Projects
None yet
Milestone
2023 Q4 - Sprint 5
Development

Successfully merging this pull request may close these issues.
4 participants
@kazaky @SimonMarquis @soulcramer @spark-ui-bot