Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce the amount of screenshots by component by grouping them into one #927

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

soulcramer
Copy link
Contributor

📋 Changes

  • Remove redundant screenshots and grouped them in one when it can fit and without loosing too much quality since we're fixed to a 1000x1000 pixels max size for now.
  • Replaced some showkase screenshots with more edible one in the module, this will help us remove showkase little by little.
  • Add the missing documentation and screenshots for the snackbar component.
  • "Fix" the new screenshots from the textlink component check that it support light/dark theme with different locale.
  • Add a unit test to button to check that the loading indicator does appear without having to setup a gidf screenshots since they're not ready for Compose yet (but "soon" they should be 🤔)

🤔 Context

Aim to close #882

✅ Checklist

  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.

📸 Screenshots

All of them are available in the review but be aware that a lot of files are changed and not all screenshots will be visible without explicitly opening them in the ui

🗒️ Other info

Next we should replace the screenshots from showkase and build our own to get back to simples previews and more exhaustive and lisible screenshots

@soulcramer soulcramer added the Enhancement New feature or request label Jan 30, 2024
@soulcramer soulcramer self-assigned this Jan 30, 2024
@soulcramer soulcramer requested review from SimonMarquis, kazaky and a team as code owners January 30, 2024 15:30
Copy link
Contributor

🚨 UI regression detected! Checkout the paparazzi-delta artifact.
If these changes are expected, you can either:

  • manually run the gradlew recordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

Copy link

@kazaky kazaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@soulcramer soulcramer added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit 03c5d9c Feb 5, 2024
6 checks passed
@soulcramer soulcramer deleted the screenshot-clean branch February 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Cleanup screenshots
2 participants