Only create service with serviceMonitor #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/S
|
I don't get what the check tries to tell me here: |
eyenx
approved these changes
Sep 12, 2024
Only create the service when `serviceMonitor.create` is set. The service is useless otherwise. I have a project where I can only use the `prometheusRules.enabled=true` but only want to use the prometheus rules, not the service monitor. Also, it creates a conflict in our deployment because we already have a similar service with that name `vault-monitoring`.
|
I quickly tested these CI commands offline. It seems be working when I set |
The `ct lint` command fails with a nil pointer. I assume it cannot find some directory.
in0rdr
force-pushed
the
feat/vault-monitoring/conditional-service-monitor
branch
from
f5685d4
to
d791995
Compare
|
I think there's a bug in that "Pluto" magic stuff. $ tail -n1 ./hack/pluto.sh
helm template $chart_dir | pluto detect -$ helm template ./charts/vault-monitoring
Error: template: vault-monitoring/templates/service.yaml:1:14: executing "vault-monitoring/templates/service.yaml" at <.Values.serviceMonitor.create>: nil pointer evaluating interface {}.create
Use --debug flag to render out invalid YAML |
|
@eyenx the |
in0rdr
deleted the
feat/vault-monitoring/conditional-service-monitor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only create the service when
serviceMonitor.createis set. The service is useless otherwise.Background: I have a project where I can only use the
prometheusRules.enabled=truebut only want to use the prometheus rules, not the service monitor. Also, it creates a conflict in our deployment, because we already have a similar service with that namevault-monitoring.