Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kubernetes-etcd-backup): bump appVersion to 1.2.1 #1324

Merged
merged 1 commit into from
Oct 1, 2024
Merged

chore(kubernetes-etcd-backup): bump appVersion to 1.2.1 #1324

merged 1 commit into from
Oct 1, 2024

Conversation

vmaillot
Copy link
Contributor

@vmaillot vmaillot commented Oct 1, 2024 •
edited
Loading

Description

v1.2.0 previous tag did not exist, we now use the correct one.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@vmaillot
chore(kubernetes-etcd-backup): bump appVersion to 1.2.1
dca88bf 
Signed-off-by: Valentin Maillot <valentin.maillot@adfinis.com>
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 1, 2024
@vmaillot vmaillot marked this pull request as ready for review October 1, 2024 07:28
@vmaillot vmaillot requested a review from a team as a code owner October 1, 2024 07:28
@vmaillot vmaillot self-assigned this Oct 1, 2024
@vmaillot vmaillot requested a review from eyenx October 1, 2024 07:28
hairmare
hairmare approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's why i got mail from artifacthub :)

LGTM

@vmaillot vmaillot merged commit dcd8ab3 into main Oct 1, 2024
3 checks passed
@vmaillot vmaillot deleted the chore/bump-kubernetes-etcd-backup-to-1.2.1 branch October 1, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairmare hairmare hairmare approved these changes

@eyenx eyenx eyenx approved these changes

@isantospardo isantospardo isantospardo approved these changes

Assignees

@vmaillot vmaillot

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vmaillot @hairmare @eyenx @isantospardo