Add input_mode for FreeSWITCH compatibility #26
Conversation
|
@bklang and @benlangfeld, can I get a quick thumbs up please? |
|
@lpradovera Can you make a corresponding fix for adhearsion develop branch? |
|
@bklang I think adhearsion develop does not bundle adhearsion-ivr, does it? That said, there is one snag here. The new nio4r version (which I updated to to solve compilation errors on a variety of platforms) is ruby 2.2+ only. Is that acceptable? |
lib/adhearsion-ivr/ivr_controller.rb
Outdated
| @input_mode || :voice | ||
| else | ||
| @input_mode = val | ||
| end |
There was a problem hiding this comment.
This whole block could be simplified to @input_mode = val || @input_mode || :voice, though I would note that simply calling the method with no arguments (looking like an accessor) has the side effect of actually changing the instance's internal state by setting @input_mode = :voice
|
@bklang Good to go on this on your side? |
|
@lpradovera Would you rebase? And see if you can get the tests passing? |
|
Also, yes, it's ok to drop support for Ruby < 2.2 |
|
@bklang This really needs some love. As soon as we have time, I'll sit down and do a general sweep of all the Adhearsion parts. If dropping Ruby < 2.2 is fine, it means we can just update all of the various gems and aim for a release, as this is not the only one held up by that. |
|
@lpradovera Before merging this, I'd really like to see the tests passing on at least Ruby 2.2 or 2.3. They were passing before this PR. |
No description provided.