Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter supported audio langauges #3

Closed
wants to merge 34 commits into from

Commits on Jul 20, 2023

  1. Fix : oppia#4793 (oppia#5092)

    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    Fixes oppia#4793 
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [X] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [X] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [X] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [X] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [X] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [X] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    
    
    https://github.com/oppia/oppia-android/assets/109658545/e542f6fc-02fc-43de-a413-93fe1e49bc04
    
    
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    prafulbbandre authored Jul 20, 2023
    Configuration menu
    Copy the full SHA
    a2fdc7a View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Fixes oppia#4736: revision card textViews line wraps instead of ellip…

    …size and solves accessibility scanner issue (oppia#5095)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    Fixes oppia#4736: This PR increases the number of lines of
    ```prev_subtopic_title``` and ```next_subtopic_title``` if the text
    doesn't fit within 3 lines for large texts. And solves the accessiblity
    scanner issue.
    
    ![image](https://github.com/oppia/oppia-android/assets/110354418/c6006977-45fb-4115-9e1e-298c613294e8)![image](https://github.com/oppia/oppia-android/assets/110354418/1c106d95-f618-4104-8e31-76d58c0ba490)
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - (before)
    -
    ![image](https://github.com/oppia/oppia-android/assets/110354418/4ffd95c3-f445-4142-a2b2-0e4fd8f743d9)
    -
    ![image](https://github.com/oppia/oppia-android/assets/110354418/33e813a4-f404-4f93-86a6-e8075688d2e4)
    - (after)
    -
    ![image](https://github.com/oppia/oppia-android/assets/110354418/54356eef-4a60-49c3-a721-70000437879e)
    -
    ![image](https://github.com/oppia/oppia-android/assets/110354418/d07b7511-a682-4a27-acaa-5788cff1d08c)
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    -
    ![image](https://github.com/oppia/oppia-android/assets/110354418/5ded08c7-058d-4aaf-a806-a4239851fbe6)
    -
    ![image](https://github.com/oppia/oppia-android/assets/110354418/13efd801-ec31-4adb-9c0d-9e0fdc60b88b)
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    Abinash6000 authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    df820f7 View commit details
    Browse the repository at this point in the history
  2. Fix some typo in string file (oppia#5105)

    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    Fix some typo in string file
    
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [ ] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [ ] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    MohitGupta121 authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2aac25b View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Configuration menu
    Copy the full SHA
    67fb399 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Fix oppia#5017 : Updated example screenshots in wiki as per new oppia…

    …-android ui (oppia#5107)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    
    Fix oppia#5017 : Updated example screenshots in wiki as per new oppia-android
    ui
    
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [ ] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    MohitGupta121 authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    faf148b View commit details
    Browse the repository at this point in the history
  2. Fix part of oppia#3690 : Wiki update - How to run static CI check loc…

    …ally (oppia#5108)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    
    Fix part of oppia#3690 : Wiki Update - How to run static CI check locally
    
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [ ] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    MohitGupta121 authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    3e81ff6 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Fix oppia#5086 : Implement Dark Mode support for NPS Survey (oppia#5104)

    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    
    Fix oppia#5086 : Implement full Dark Mode support for NPS Survey
    
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [ ] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    
    ### NPS Survey Welcome Screen
    
    | Light Mode | Dark Mode |
    | ------ | ------ |
    | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/0cad1b6a-6927-44ee-94e9-1fc6fd79d703"
    height="400" style="max-width: 100%"> | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/8e5216f5-e8d0-4720-9187-4382d9aa3701"
    height="400" style="max-width: 100%"> |
    
    ### NPS Survey Question screen (Button Disabled)
    
    | Light Mode | Dark Mode |
    | ------ | ------ |
    | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/f03c3773-8a1e-484d-9630-7d1305c0a9d7"
    height="400" style="max-width: 100%"> | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/4728e8a9-4de6-4db7-a022-64921a4179e3"
    height="400" style="max-width: 100%"> |
    
    ### NPS Survey Question screen (Button Enabled)
    
    | Light Mode | Dark Mode |
    | ------ | ------ |
    | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/c331cea5-d80c-404c-b4c9-a60540661136"
    height="400" style="max-width: 100%"> | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/768d6d55-532b-4c6d-b939-2fd0df5667f9"
    height="400" style="max-width: 100%"> |
    
    ### NPS Survey Score Screen
    
    | Light Mode | Dark Mode |
    | ------ | ------ |
    | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/16af2177-db90-4370-a1e9-e04cec0677a0"
    height="400" style="max-width: 100%"> | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/0cfeb8a6-6c52-4177-9b91-f6854a52d3b8"
    height="400" style="max-width: 100%"> |
    
    ### NPS Survey Final comment screen (Button Enabled)
    
    | Light Mode | Dark Mode |
    | ------ | ------ |
    | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/790b665f-a3ca-4b12-b04f-c60be6159632"
    height="400" style="max-width: 100%"> | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/0007c758-3900-4a7e-a9ab-da536125f06a"
    height="400" style="max-width: 100%"> |
    
    ### NPS Survey Final comment screen (Button Disabled)
    
    | Light Mode | Dark Mode |
    | ------ | ------ |
    | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/a26e9da7-0b4b-4357-96ba-fee361daeba2"
    height="400" style="max-width: 100%"> | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/08695850-f8fb-4227-80bd-c4f1cd35640f"
    height="400" style="max-width: 100%"> |
    
    
    
    ### NPS Survey Thanks You screen
    
    | Light Mode | Dark Mode |
    | ------ | ------ |
    | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/ec5d694e-798d-41d2-9ca7-aacfd23bf00e"
    height="400" style="max-width: 100%"> | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/13fa3fc2-3f00-470e-87bf-7c1906a06677"
    height="400" style="max-width: 100%"> |
    
    ### NPS Survey Exit Dialog
    
    | Light Mode | Dark Mode |
    | ------ | ------ |
    | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/317385d3-5365-443c-905c-6a91457bbfa9"
    height="400" style="max-width: 100%"> | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/2fbbed49-90b0-42e6-a579-d5aad9675057"
    height="400" style="max-width: 100%"> |
    
    
    
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    -
    
    ---------
    
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    MohitGupta121 and adhiamboperes authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a888729 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Fixes oppia#4737: No meaningful label of the revision screen navigati…

    …on cards during talkback. (oppia#5113)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    Fixes oppia#4737 
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    
    
    [talkback.webm](https://github.com/oppia/oppia-android/assets/92685493/c897e62f-3c8f-467f-88a8-e792f2974998)
    
    ---------
    
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    Akshatkamboj14 and adhiamboperes authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    37265c5 View commit details
    Browse the repository at this point in the history
  2. Fix oppia#5016: Dark mode wiki update (oppia#5097)

    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    This PR adds more information to Dark-Mode wiki page.
    
    Fix oppia#5016: Dark mode wiki update
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    rt4914 authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    2b3213c View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Fix part of oppia#4391: Fix failing build on m1 macs (oppia#5111)

    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    Fix part of oppia#4391 : Fix failing build on M1 Macs
    ## Explanation
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    Some M1 Macs fail to build the Oppia app because of unused imports in
    some of the proto files in the project. This PR attempts to fix this
    issue by removing unused imports in proto files. Files affected by this
    fix are;
    - profile.proto
    - deprecation.proto
    
    This is a temporary fix and more investigation will need to be done to
    properly understand why this behavior is erratic and why it only happens
    in some instances and not in others. More checks are also needed to
    ensure that proto files only have imports that are used in the proto
    file before they are merged.
    
    Besides build fixes, this PR also;
    - Includes a fix for the `buildifier_download.sh` which previously did
    not work for MacOS users.
    - Introduces a `static_checks.sh` file to allow contributors to run all
    static checks locally before pushing the code to Git.
    - Adds a wiki entry in the Static-Analysis-Checks wiki. The entry
    contains instructions on how to run static checks locally with the
    static_checks.sh file.
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ---------
    
    Co-authored-by: Kenneth Murerwa <kkmurerwa@Kenneths-MacBook-Air.local>
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    3 people authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d55b7e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. Remove unwanted condition from dark-mode wiki (oppia#5117)

    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    
    As per suggested by @rt4914 in this issue
    [comment](oppia#5114 (comment))
    we have to remove that line from wiki to close that issue.
    
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [ ] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [ ] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    MohitGupta121 authored Aug 5, 2023
    Configuration menu
    Copy the full SHA
    5340492 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Fix oppia#5121 : The Testing Page on the Wiki Contains Broken Links t…

    …o Code Files (oppia#5122)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    
    Fix oppia#5121 : The Testing Page on the Wiki Contains Broken Links to Code
    Files
    
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [ ] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    MohitGupta121 authored Aug 6, 2023
    Configuration menu
    Copy the full SHA
    c225110 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Fix oppia#4803 Failed to add Admin (or non-admin) Profile Picture. (o…

    …ppia#5118)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    
    - Fix oppia#4803 
    val galleryIntent = Intent(Intent.ACTION_PICK,
    MediaStore.Images.Media.EXTERNAL_CONTENT_URI)
    The above code (previous) is the explicit way to get images from gallery
    but is not working here. But the updated code below is less explicit but
    works fine,
    val galleryIntent = Intent(Intent.ACTION_GET_CONTENT).apply { type =
    "image/*" }
    
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## Screen Recording
    
    
    https://github.com/oppia/oppia-android/assets/99060332/b6379a06-e3e6-41eb-9bed-de6271dcd346
    
    ---------
    
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    ShubhadeepKarmakar and adhiamboperes authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d58c816 View commit details
    Browse the repository at this point in the history
  2. Fix oppia#5120 Missing Text Margins In Topic Revision Cards in Large …

    …Screens (oppia#5127)
    
    ## Explanation
    Fix oppia#5120 [Missing Text Margins In Topic Revision Cards in Large
    Screens](oppia#5120)
    
    Added layout_marginStart and layout_marginEnd in
    oppia-android/app/src/main/res/layout-sw600dp/revision_card_fragment.xml
    <img width="846" alt="Screenshot 2023-08-09 at 4 52 46 PM"
    src="https://github.com/oppia/oppia-android/assets/121669947/b2ed2602-2e5c-4124-a856-f6209e3dc0a1">
    
    
    Absence of marginStart and marginEnd caused missing text margins on
    Large Screens.
    
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    
    
    ## Screenshots
    **before fix:**
    ![padding and
    margin](https://github.com/oppia/oppia-android/assets/121669947/a50dd61f-2574-493d-a482-720bbe6d5970)
    
    **after fix:**
    
    ![ratiocorrect](https://github.com/oppia/oppia-android/assets/121669947/69261f78-6f66-4aa1-a616-8827f7108035)
    
    ---------
    
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    pingu-73 and adhiamboperes authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b408804 View commit details
    Browse the repository at this point in the history
  3. Fix oppia#5119 TopicActivity Has Dark Mode Inconsistencies in Large S…

    …creens (oppia#5128)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
      - Fixes oppia#5119 
    tabBackground(TabLayout) is not enough for large screens, that's why I
    give the background to the parent i.e. background of AppBarLayout.
    - AppBarLayout
      - ToolBar
      - TabLayouyt
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    
    ### Before:
    
    ![image](https://user-images.githubusercontent.com/59600948/258624288-4d9248a7-c17b-4d4b-b35e-a7b9126d3367.png)
    
    
    ### After:
    Tablet in Portrait, Dark Mode
    
    ![darkmode](https://github.com/oppia/oppia-android/assets/99060332/521aba11-8f63-4488-896c-09b53d76ae26)
    
    Tablet in Landscape, Dark Mode
    
    ![tablet_in_landscape_dark_mode](https://github.com/oppia/oppia-android/assets/99060332/b257aeaa-0b53-4573-9950-ddbd043f3141)
    
    Tablet in Portrait, Light Mode
    
    ![tablet_in_portrait_light_mode](https://github.com/oppia/oppia-android/assets/99060332/a87939bd-98c2-49b3-b0d4-406a5b85847e)
    
    Tablet in Landscape, Light Mode
    
    ![tablet_in_landscape_light_mode](https://github.com/oppia/oppia-android/assets/99060332/d1c46906-dd00-4148-ad73-8b90d7bd7754)
    
    Phone in Portrait, Dark Mode
    
    ![pipdm](https://github.com/oppia/oppia-android/assets/99060332/4b54e908-f18d-4c47-82f2-5ca7bf7d19f2)
    
    
    Phone in Landscape, Dark Mode
    
    ![pildm](https://github.com/oppia/oppia-android/assets/99060332/1689804f-1c1d-4d2b-99b2-6609d45a417c)
    
    
    Phone in Portrait, Light Mode
    
    ![phone_in_portrait_light_mode](https://github.com/oppia/oppia-android/assets/99060332/174ca81c-6a8d-4734-99a7-d4220345d472)
    
    Phone in Landscape, Light Mode
    
    ![pillm](https://github.com/oppia/oppia-android/assets/99060332/59599cf1-2907-4996-b152-0a7b26bfb496)
    
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    ShubhadeepKarmakar and adhiamboperes authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b97ad8a View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Fix oppia#4710 Resume Lesson Fragment Button Responsiveness, Icon Lay…

    …out, and Dark Mode Color (oppia#5116)
    
    Fix oppia#4710 the button scaling problem in largest text setting in the
    resume fragment, and fix the color change in dark mode.
    
    The use of material button has better control for the icon inside the
    button so that it can group icons and text together as responsive design
    guidelines suggested. Particularly the icon gravity part that attached
    the icon to the text. Also, add flex layout so that button will wrap to
    two lines when the screen is too small.
    
    Set app:backgroundTint = "@null" fixes the auto color change made by the
    app in the dark mode.
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    
    Here are the testing on my own cell phone, even the second smallest text
    is too large for the screen so the buttons are wrapped in two rows. Only
    the smallest text can fit.
    |Screenshot 1|Screenshot 2|Screeshot 3|
    |--|--|--|
    |![Weixin
    Image_20230606114148](https://github.com/oppia/oppia-android/assets/74568012/45a9e17f-d021-415a-860c-8c71cdada757)|![Weixin
    Image_20230606114203](https://github.com/oppia/oppia-android/assets/74568012/55fe69d7-5da0-47b6-8b3a-f5c1840c1fd4)|![Weixin
    Image_20230606114209](https://github.com/oppia/oppia-android/assets/74568012/a998b295-c956-4bc2-a575-e90df07ffa70)|
    
    
    - Add a screenshot demonstrating UI of tablet
    |Screenshot 1| Screenshot 2|
    |--|--|
    |![Screenshot 2023-06-05
    120237](https://github.com/oppia/oppia-android/assets/74568012/1b49da46-2313-400e-a5c1-e89c54d41a42)|![Screenshot
    2023-06-05
    120223](https://github.com/oppia/oppia-android/assets/74568012/f0593f2f-4848-4050-9f8c-d7859a61f0fc)|
    
    LTR
    |Screenshot 1|Screenshot 2|Screeshot 3|
    |--|--|--|
    
    |![Image_20230606114738](https://github.com/oppia/oppia-android/assets/74568012/23e53655-9d3a-4f1f-a82c-a1bf7d2ca432)|![Image_20230606114706](https://github.com/oppia/oppia-android/assets/74568012/7a416ec8-bf23-4ffe-ad92-a7be013f5b99)|![Image_20230606114719](https://github.com/oppia/oppia-android/assets/74568012/70aa810a-b85d-4958-b8a2-e5d15c5a5e22)|
    
    - Dark Mode Fix
    | Before | After |
    |:------:|:-----:|
    |
    ![image](https://github.com/oppia/oppia-android/assets/74568012/8f1d968c-7750-4015-97f5-f0de847a9b8f)
    |
    ![image](https://github.com/oppia/oppia-android/assets/74568012/b63d7ab4-4e8f-4507-9609-c2413dcbc709)
    |
    
    
    |![image](https://github.com/oppia/oppia-android/assets/74568012/3c4d1c7b-0e69-4213-a0d6-0fd7b5c94ed1)|![image](https://github.com/oppia/oppia-android/assets/74568012/ac270065-72ee-4623-b423-4267acede6f1)|
    
    ---------
    
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    XichengSpencer and adhiamboperes authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    bb8f34e View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Fix oppia#4607 : [Developer Video] How to use an Accessibility Scanne…

    …r? (oppia#5129)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    
    Fix oppia#4607 : [Developer Video] How to use an Accessibility Scanner?
    
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [ ] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    MohitGupta121 authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    d74576d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Fix oppia#5094 : [Wiki update] Bazel build failed in mac m1 (oppia#5139)

    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    
    Fix oppia#5094 : [Wiki update] Bazel build failed in mac m1
    
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [ ] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    MohitGupta121 authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c5b11fe View commit details
    Browse the repository at this point in the history
  2. Fix oppia#4735 Text unit is set in dp instead of sp (oppia#5134)

    ## Explanation
    Fix oppia#4735 , Added toolbar in admin_pin_activity xml file inorder to
    control the title size using sp.
    
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    
    Before fix
    Admin pin activity
    | Light mode| 
    |--------|
    |![before
    light](https://github.com/oppia/oppia-android/assets/76042077/e80cd747-b04c-43c5-96b9-848dc5db3400)
    |
    
    After fix
    |Light mode| Dark mode|
    |-----------|--------------|
    |
    ![afterlightmode](https://github.com/oppia/oppia-android/assets/76042077/4445ebd1-3fde-40f4-a4cb-cb3716aad43e)
    |
    ![afterdarkmode](https://github.com/oppia/oppia-android/assets/76042077/98bd0994-5f4d-464f-b170-d21e167a9eaa)
    |
    
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    Vishwajith-Shettigar and adhiamboperes authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    7668bf0 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Fix oppia#5142 Edit text foreground and background contrast ratio iss…

    …ue in Light mode (oppia#5144)
    
    ## Explanation
    Fix oppia#5142, changed text input default stroke color.
    Added color resource file names component_color_text_layout.xml in order
    to give stroke color
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    
    Berore fix
    | Light mode| Dark mode|
    |--------|--------|
    |
    ![contarstlight_before](https://github.com/oppia/oppia-android/assets/76042077/0fcb4613-a7fb-4320-ae88-792704d61950)|![contastdark_before](https://github.com/oppia/oppia-android/assets/76042077/d36c6c13-654a-4603-8cef-80472dacf0d3)|
    
    Afterfix
    | Light mode| Dark mode|
    |--------|--------|
    
    |![newnew](https://github.com/oppia/oppia-android/assets/76042077/ef50252b-7c21-41ab-baee-2f244e87644b)|![contrastdark_after](https://github.com/oppia/oppia-android/assets/76042077/e4418fb6-9fb1-4c32-8c54-339235303abb)|
    
    Screen recording after fix
    
    Light mode
    
    
    https://github.com/oppia/oppia-android/assets/76042077/943629a3-2b4a-4459-bbf9-0f0246860ffd
    
    Dark mode
    
    
    https://github.com/oppia/oppia-android/assets/76042077/c85256a0-5f99-4577-82e4-b95ce0d24027
    
    
    
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    Vishwajith-Shettigar authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a1ba8bd View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Fix oppia#4608 : [Developer Video] How to use Talkback - screen reade…

    …r and what does its output mean? (oppia#5148)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    
    Fix oppia#4608 : [Developer Video] How to use Talkback - screen reader and
    what does its output mean?
    
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    MohitGupta121 authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    5e74b84 View commit details
    Browse the repository at this point in the history
  2. Fix oppia#3122 : Dark theme make colors of the images distorted (oppi…

    …a#5141)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    
    Fix oppia#3122 : Dark theme make the colors of the images distorted
    
    Solution: Images change their color to white when Dark mode is turned
    on. That's why we force disabling dark mode for Image Views prevents
    android from force-inverting the colors in the images.
    
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    
    | Before Fix | After Fix |
    | ------ | ------ |
    | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/dafd6370-c180-4ca6-bc92-0af8e528728e"
    height="400" style="max-width: 100%"> | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/95ac7d75-3459-4acb-b682-d98a48803073"
    height="400" style="max-width: 100%"> |
    
    | Before Fix | After Fix |
    | ------ | ------ |
    | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/6d483477-dc8b-4399-b043-cb11f6295480"
    height="400" style="max-width: 100%"> | <img
    src="https://github.com/oppia/oppia-android/assets/76530270/3d3ab830-9cb2-4275-9e44-7f395d574ad2"
    height="400" style="max-width: 100%"> |
    
    
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    MohitGupta121 authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b643538 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Fix oppia#4790 Talkback will read toolbar title clickable (oppia#5027)

    Fix oppia#4790 For toolbars that have marquee effects, add additional checks
    so that the effect will only be enabled when the accessibility service
    is not on.
    Also updated the existing test for the marquee effect. The test now
    checks if the effect is set and activated correctly depending on the
    accessibility service status.
    Update the test setting to ensure that test behavior is correctly
    simulated.
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    
    Whenever users use vocal assisting tools such as talkback, the
    accessibility service we inject in the field will be enabled. We will
    choose either to use a marquee effect for visual display, or just pure
    vocal display when the user enables the service.
    
    For a toolbar that doesn't have an individual view for the toolbar
    title, setting 'onNavgation..listener' will make the whole toolbar
    clickable, and talkback will read "double click.."-
    While we want to keep the navigation function, we can use getChildAt(0)
    to set the listener to just the nav icon.
     
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    Exploration Activity:
    
    - Normal:
    
    
    https://github.com/oppia/oppia-android/assets/74568012/74f6eaf8-8560-4d1a-bfb4-d378177e31b6
    
    - Talkback On:
    
    
    https://github.com/oppia/oppia-android/assets/74568012/11285aee-ed5e-4355-97b1-c18df646efd7
    
    Topic Fragment:
    
    - Talkback On:
    
    
    https://github.com/oppia/oppia-android/assets/74568012/f8cec635-b1c3-4540-afcb-990a42a9a38b
    
    
    ## Issue with Espresso test:
    when readerOff, toolbar.title.click() behaves different from manual
    test.
    
    - Video record for manual test 
    
    Listener function is set and is called when click is performed.
    Regardless of title length, is selected will always be modified.
    
    
    https://github.com/oppia/oppia-android/assets/74568012/7f9a04b6-e3e3-4803-9465-89543b091458
    
    
    - Video record for espresso test 
         Listener function is set but not called when click is performed.
         The isSelected attribute does not been modified after click
        
    
    
    https://github.com/oppia/oppia-android/assets/74568012/c2984b5f-c9fe-4a35-a36f-27d05a935210
    
    ## Solution to Solve Error in Espresso Tests.
    
    - Setting the accessibility service before starting the activity solves
    accessibility service not correctly set except in TopicFragmentTest.
    **Reason** The set listener code in the app executes before setting the
    accessibility service in the test.
    
    - Add markSpotlightSeen before the start of the activity.
    **Reason** The spotlight might cause the toolbar unable to reach to
    simulate a click.
    XichengSpencer authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    89e8032 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Fix oppia#5075: Exempt Existing Vectors from ColorHex Checks (oppia#5123

    )
    
    ## Explanation
    Fixes oppia#5075. 
    This PR adds back the color hex regex check removed in oppia#5076. This
    requires a static check exemption for two vectors in the `drawable`
    directory, `survey_nps_radio_selected_color.xml` and
    `survey_nps_radio_unselected_color.xml`.
    
    The check `file_path_regex: "app/src/main/res/drawable.*?/.+?\\.xml"`
    blanket checks all drawables, including vectors. Since these cannot
    fully be changed to use component colors yet, I think that the best
    approach is to exempt them from the check.
    
    This is a replacement of PR oppia#5081, since oppia#5081 would nolonger be a clean
    revert.
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    
    ---------
    
    Co-authored-by: Ben Henning <ben@oppia.org>
    adhiamboperes and BenHenning authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c28b8ee View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Fix oppia#3843 Split Concatenated TextView (oppia#5151)

    ## Explanation
    Fix oppia#3843 Instead of using 1 textview to display a concatenated string,
    now have 1 textview for story progress, 1 for bar separator, and 1 for
    topic progress.
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    
    |LTR|RTL|
    |---|---|
    
    |![Screenshot_20230913_170309](https://github.com/oppia/oppia-android/assets/74568012/5d10ee41-41cb-46f1-b37d-b368e247c108)|![Screenshot_20230913_170148](https://github.com/oppia/oppia-android/assets/74568012/d5ee32ce-1899-4e5c-825c-3070f5e132ad)|
    
    |![Screenshot_20230913_165312](https://github.com/oppia/oppia-android/assets/74568012/4435074e-41b3-4b0b-9dd1-7cfc1b3bfd72)|![Screenshot_20230913_170218](https://github.com/oppia/oppia-android/assets/74568012/476060ea-15b8-4636-afa0-89fdb130d05b)|
    
    
    
    
    ## Tests
    ![Screenshot 2023-09-15
    101749](https://github.com/oppia/oppia-android/assets/74568012/2ee79906-22e8-42a0-b3b6-b71676b50f92)
    
    ---------
    
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    XichengSpencer and adhiamboperes authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    cfce93c View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2023

  1. Fix oppia#3841: Combine time and quantity plurals (oppia#5153)

    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->Fixes oppia#3841 
    
    This PR involves Combining plurals and quantity strings from:
    ` <string name="time_ago">%s ago</string>`
    
    and
    
    ```
    <plurals name="minutes">
      <item quantity="one">a minute</item>
      <item quantity="other">%s minutes</item>
    </plurals>
    ```
    
    to
    
    ```
     <plurals name="minutes_ago">
        <item quantity="one">a minute ago</item>
        <item quantity="other">%s minutes ago</item>
      </plurals>
    ```
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    
    | BEFORE  | AFTER |
    | ------------- | ------------- |
    |
    ![Before](https://github.com/oppia/oppia-android/assets/92685651/f3daf711-b96d-4ca7-8e49-d13c14769fb4)|
    ![after](https://github.com/oppia/oppia-android/assets/92685651/e303564a-9961-49fb-8258-75743bc5fb51)
    |
    |
    ![arabicbefore](https://github.com/oppia/oppia-android/assets/92685651/9c9d5c34-9ebb-42c3-9176-f69775f28e58)
    |![afterarabic](https://github.com/oppia/oppia-android/assets/92685651/471799da-10e9-4691-beb5-3b87edea1e8f)
    |
    
    ---------
    
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    aayushimathur6 and adhiamboperes authored Sep 24, 2023
    Configuration menu
    Copy the full SHA
    0898127 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Fixes oppia#4539: Replace CaseSensitiveEquals by Equals in dev assets (

    …oppia#5154)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    Fixes oppia#4539: Replace the rule type CaseSensitiveEquals by Equals in dev
    assets. This only affects the topics used in dev environment. The rule
    type CaseSensitiveEquals is no longer supported.
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    
    
    **Videos**
    
    |current|new|
    |-|-|
    
    |[fix_for_CaseSensitiveEquals_current.webm](https://github.com/oppia/oppia-android/assets/103062089/0ad9f1e9-a991-4908-8576-1aba964fadcb)|[fix_for_CaseSensitiveEquals_new.webm](https://github.com/oppia/oppia-android/assets/103062089/298270d9-6af2-4cb8-a9f0-6445e5abfdd6)|
    
    **Screenshots**
    
    |current|new|
    |-|-|
    |![Screenshot
    fix_for_CaseSensitiveEquals_current](https://github.com/oppia/oppia-android/assets/103062089/b135fce1-270e-46d9-b819-82833011988d)|![Screenshot
    fix_for_CaseSensitiveEquals_new](https://github.com/oppia/oppia-android/assets/103062089/443f966f-717b-4fab-b17a-11d52e817737)|
    
    ---------
    
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    masclot and adhiamboperes authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    42ee1bd View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Fix oppia#5079: Gradle Build Failed - Task :utility:kaptGenerateStubs…

    …DebugKotlin FAILED (oppia#5162)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    Fixes oppia#5079
    
    The error message indicates that there's a compatibility issue with the
    Java version being used for the project. The `Unsupported class file
    major version 59` suggests that the code in the model.jar (project
    :model) file is compiled with a Java version higher than the one being
    used by the project.
    
    This PR explicitly set the source and target compatibility to Java 8 for
    the project. This ensures that the project uses Java 8, which is
    compatible with class files compiled with major version 59 (Java 15).
    
    By making this change, we ensure that the project's Java version aligns
    with the Java version used to compile the model.jar file, thus resolving
    the compatibility issue and allowing the build process to proceed
    without errors.
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    theMr17 authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    41f74fc View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. Fix oppia#5136: Modifies all caps buttons to sentence case (oppia#5157)

    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    Fixes oppia#5136
    
    This PR changes all caps buttons to sentence case. All buttons mentioned
    in this
    [comment](oppia#5136 (comment))
    are changed either by directly changing its `android:textAllCaps` to
    `false` in the layout files or by changing its style in the `styles.xml`
    file.
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    
    ## Screenshots
    
    ### _layout_
    
    |Screen / Dialog|Button ID|Screenshots|
    |--|--|--|
    |`activity_input_interaction_view_test.xml`|`submit_button`|
    |`add_profile_activity.xml`|`add_profile_activity_create_button`|
    |`admin_auth_activity.xml`|`admin_auth_submit_button`|
    |`admin_pin_activity.xml`|`submit_button`|
    |`concept_card_fragment_test_activity.xml`|`open_dialog_0`
    `open_dialog_1`|
    |`exploration_test_activity.xml`|`play_exploration_button`|
    
    |`hint_summary.xml`|`reveal_hint_button`|![image](https://github.com/oppia/oppia-android/assets/84731134/fa55e84f-df00-47fc-9064-6ba57dc91337)|
    
    |`math_expression_parser_fragment.xml`|`parse_math_expression_button`|![image](https://github.com/oppia/oppia-android/assets/84731134/97678f0a-294f-40e9-a057-cd59843a07c9)|
    
    |`onboarding_slide_final.xml`|`get_started_button`|![image](https://github.com/oppia/oppia-android/assets/84731134/44dab2e5-af61-42b6-a9be-977f0c3487a3)|
    
    |`profile_list_control_buttons.xml`|`learner_analytics_share_ids_and_events_button`
    `learner_analytics_upload_logs_now_button`|
    
    |`profile_rename_fragment.xml`|`profile_rename_save_button`|![image](https://github.com/oppia/oppia-android/assets/84731134/6834670a-6225-45a1-a845-f41bc464a711)|
    |`profile_reset_pin_fragment.xml`|`profile_reset_save_button`|
    |`replay_button_item.xml`|`replay_button`|
    
    |`return_to_lesson_button_item.xml`|`return_to_lesson_button`|![image](https://github.com/oppia/oppia-android/assets/84731134/fa55e84f-df00-47fc-9064-6ba57dc91337)|
    |`return_to_topic_button_item.xml`|`return_to_topic_button`|
    |`solution_summary.xml`|`show_solution_button`|
    |`state_fragment_test_activity.xml`|`play_test_exploration_button`|
    
    |`submit_button_item.xml`|`submit_answer_button`|![image](https://github.com/oppia/oppia-android/assets/84731134/eed9fb84-b4d8-4d65-a665-813c641debc5)|
    |`topic_practice_footer_view.xml`|`topic_practice_start_button`|
    |`walkthrough_welcome_fragment.xml`|`walkthrough_welcome_next_button`|
    
    ### _layout-land_
    |Screen / Dialog|Button ID|Screenshots|
    |--|--|--|
    
    |`onboarding_slide_final.xml`|`get_started_button`|![image](https://github.com/oppia/oppia-android/assets/84731134/ce6df192-62ee-481b-83ea-49a56a4dfbe3)|
    |`walkthrough_welcome_fragment.xml`|`walkthrough_welcome_next_button`|
    
    ### _layout-sw600dp-land_
    |Screen / Dialog|Button ID|
    |--|--|
    |`onboarding_slide_final.xml`|`get_started_button`|
    
    ### _layout-sw600dp-port_
    |Screen / Dialog|Button ID|
    |--|--|
    |`onboarding_slide_final.xml`|`get_started_button`|
    
    <img
    src="https://github.com/oppia/oppia-android/assets/84731134/23e8ebbb-386d-4dfa-bf4a-6e8354734245"
    width="300"/>
    <img
    src="https://github.com/oppia/oppia-android/assets/84731134/e1358ff6-9e5e-4ae6-a9bc-44490f48d022"
    width="300"/>
    <img
    src="https://github.com/oppia/oppia-android/assets/84731134/10c06098-0e4a-47a5-b7c3-988fc97073f2"
    width="300"/>
    <img
    src="https://github.com/oppia/oppia-android/assets/84731134/08d9c601-8c46-430c-ba17-f7dbcd131d4a"
    width="300"/>
    
    ---------
    
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    theMr17 and adhiamboperes authored Sep 30, 2023
    Configuration menu
    Copy the full SHA
    9bbf94a View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2023

  1. Fix oppia#4649: Updates audio option name (oppia#5165)

    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    Fixes oppia#4649
    
    This PR changes the `audio_language` & `audio_language_activity_title`
    string in `strings.xml` file to `Preferred Audio Language`.
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    
    <img
    src="https://github.com/oppia/oppia-android/assets/84731134/ee45c13d-5181-4cc8-991c-73a204884eae"
    width="300"/>
    <img
    src="https://github.com/oppia/oppia-android/assets/84731134/b4cc6942-43fa-45f5-8dd0-081eeae7b064"
    width="300"/>
    theMr17 authored Oct 1, 2023
    Configuration menu
    Copy the full SHA
    716d3a0 View commit details
    Browse the repository at this point in the history
  2. Fix oppia#5164 Format strings.xml(values-en) so that string tags are …

    …on one line (oppia#5166)
    
    <!-- READ ME FIRST: Please fill in the explanation section below and
    check off every point from the Essential Checklist! -->
    ## Explanation
    Fix oppia#5164 , format the strings.xml(values-en).
    Because some strings are multiline, they are parsed with newlines on
    translatewiki which cascades down to the translated strings. This causes
    a problem with display. So formatted them to single line
    <!--
    - Explain what your PR does. If this PR fixes an existing bug, please
    include
    - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
    issue
      - when this PR is merged.
      -->
    
    ## Essential Checklist
    <!-- Please tick the relevant boxes by putting an "x" in them. -->
    - [x] The PR title and explanation each start with "Fix #bugnum: " (If
    this PR fixes part of an issue, prefix the title with "Fix part of
    #bugnum: ...".)
    - [x] Any changes to
    [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
    files have their rationale included in the PR explanation.
    - [x] The PR follows the [style
    guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
    - [x] The PR does not contain any unnecessary code changes from Android
    Studio
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
    - [x] The PR is made from a branch that's **not** called "develop" and
    is up-to-date with "develop".
    - [x] The PR is **assigned** to the appropriate reviewers
    ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
    
    ## For UI-specific PRs only
    <!-- Delete these section if this PR does not include UI-related
    changes. -->
    If your PR includes UI-related changes, then:
    - Add screenshots for portrait/landscape for both a tablet & phone of
    the before & after UI changes
    - For the screenshots above, include both English and pseudo-localized
    (RTL) screenshots (see [RTL
    guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
    - Add a video showing the full UX flow with a screen reader enabled (see
    [accessibility
    guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
    - Add a screenshot demonstrating that you ran affected Espresso tests
    locally & that they're passing
    
    Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
    Vishwajith-Shettigar and adhiamboperes authored Oct 1, 2023
    Configuration menu
    Copy the full SHA
    590ecdf View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Configuration menu
    Copy the full SHA
    1b4989c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    20ce1b0 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    50961f1 View commit details
    Browse the repository at this point in the history