CI-CD this closes #26 #141

lohaniprateek · 2025-11-23T04:52:09Z

📝 Description

A brief description of what this PR does.

🔗 Related Issue

Closes #(issue number)

🎯 Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Code refactoring
Performance improvement
Test addition or update

🧪 Testing

How has this been tested?

Unit tests
Integration tests
Manual testing
E2E tests

Test Steps:

Step 1
Step 2
Step 3

📸 Screenshots (if applicable)

Add screenshots to help explain your changes.

✅ Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published

🔍 Review Notes

Any special notes for reviewers:

Note 1
Note 2

📚 Additional Context

Add any other context about the PR here.

Thank you for contributing to FairMind! 🎉

Copilot

Pull request overview

This PR introduces CI/CD infrastructure for both frontend and backend applications, addressing issue #26. It adds GitHub Actions workflows for automated testing, building, and deployment, along with a Dockerfile for the frontend application.

Key changes:

Added GitHub Actions workflows for frontend and backend CI/CD pipelines with test, build, and deploy stages
Introduced a multi-stage Dockerfile for the Next.js frontend application using Bun
Configured automated deployment to Railway with Docker image publishing to GitHub Container Registry

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 16 comments.

File	Description
`apps/frontend/Dockerfile`	Multi-stage Dockerfile for building and running the Next.js frontend with Bun runtime
`.github/workflows/frontend_ci.yml`	CI/CD workflow for frontend including linting, testing, Docker build/push, security scanning, and Railway deployment
`.github/workflows/backend_ci.yml`	CI/CD workflow for backend including Python linting, type checking, security scanning, Docker build/push, and Railway deployment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-27T03:58:37Z

apps/frontend/Dockerfile

+EXPOSE 3000
+
+# Command to run the application
+CMD ["bun", "run", "start"]


The CMD ["bun", "run", "start"] command on line 35 will fail because it's executed from /app, but the application files are in /app/apps/frontend/. The start command needs to run from the correct directory.

Suggested fix: Update the command to specify the working directory:

WORKDIR /app/apps/frontend CMD ["bun", "run", "start"]

Or update the CMD:

CMD ["bun", "run", "start", "--cwd", "./apps/frontend"]

Copilot · 2025-11-27T03:58:38Z

.github/workflows/frontend_ci.yml

+      - name: Deploy to Railway
+        uses: railwayapp/cli-action@v1
+        with:
+          railway_token: ${{ secrets.RAILWAY_API_TOKEN }}


The Railway deployment step is missing critical information for a successful deployment. The railwayapp/cli-action@v1 requires additional parameters such as:

service: The service name to deploy

environment: The environment to deploy to (e.g., production, staging)

Without these parameters, the deployment may fail or deploy to an unintended target.

Suggested fix:

- name: Deploy to Railway uses: railwayapp/cli-action@v1 with: railway_token: ${{ secrets.RAILWAY_API_TOKEN }} service: frontend environment: production

Suggested change

railway_token: ${{ secrets.RAILWAY_API_TOKEN }}

railway_token: ${{ secrets.RAILWAY_API_TOKEN }}

service: frontend

environment: production

Copilot · 2025-11-27T03:58:38Z

.github/workflows/backend_ci.yml

+        with:
+          context: apps/backend
+          push: true
+          tags: ghcr.io/${{ github.repository }}/backend:latest


[nitpick] The Docker image is tagged only as latest (line 57), which makes it difficult to track which version is deployed and can cause issues with rollbacks. Consider implementing a versioning strategy using commit SHA or semantic versioning.

Suggested improvement:

- name: Build and push uses: docker/build-push-action@v4 with: context: apps/backend push: true tags: | ghcr.io/${{ github.repository }}/backend:latest ghcr.io/${{ github.repository }}/backend:${{ github.sha }}

This allows you to track deployments and roll back to specific versions if needed.

Suggested change

tags: ghcr.io/${{ github.repository }}/backend:latest

tags: |

ghcr.io/${{ github.repository }}/backend:latest

ghcr.io/${{ github.repository }}/backend:${{ github.sha }}

Copilot · 2025-11-27T03:58:38Z

apps/frontend/Dockerfile

+# Copy the rest of the frontend application code
+COPY apps/frontend/ ./apps/frontend/
+
+# Build the Next.js application


The bun run build command on line 15 will fail because it's executed from /app, but the Next.js project is located in /app/apps/frontend/. The build command needs to run from the correct directory.

Suggested fix: Add --cwd flag or change working directory:

RUN bun run build --cwd ./apps/frontend

Or set the working directory:

WORKDIR /app/apps/frontend RUN bun run build

Suggested change

# Build the Next.js application

# Build the Next.js application

WORKDIR /app/apps/frontend

Copilot · 2025-11-27T03:58:39Z

.github/workflows/backend_ci.yml

+        uses: aquasecurity/trivy-action@master
+        with:
+          image-ref: 'ghcr.io/${{ github.repository }}/backend:latest'
+          format: 'table'
+          exit-code: '1'


The Trivy security scan on line 59 will attempt to scan an image that may not be publicly accessible from the GitHub Actions runner. Additionally, using @master for the action version is not a best practice as it can lead to unexpected breaking changes.

Suggested fix:

- name: Scan image uses: aquasecurity/trivy-action@0.17.0 # Use a specific version with: image-ref: 'ghcr.io/${{ github.repository }}/backend:latest' format: 'sarif' output: 'trivy-results.sarif'

Suggested change

uses: aquasecurity/trivy-action@master

with:

image-ref: 'ghcr.io/${{ github.repository }}/backend:latest'

format: 'table'

exit-code: '1'

uses: aquasecurity/trivy-action@0.17.0 # Use a specific version

with:

image-ref: 'ghcr.io/${{ github.repository }}/backend:latest'

format: 'sarif'

output: 'trivy-results.sarif'

Copilot · 2025-11-27T03:58:40Z

apps/frontend/Dockerfile

+WORKDIR /app
+
+# Install dependencies
+COPY apps/frontend/package.json apps/frontend/bun.lock ./apps/frontend/


The bun install command on line 9 will fail because it runs from /app directory, but the package.json and bun.lock are copied to /app/apps/frontend/. The install command needs to specify the correct working directory or be run from the subdirectory.

Suggested fix: Add --cwd ./apps/frontend flag:

RUN bun install --frozen-lockfile --cwd ./apps/frontend

Or change to the directory first:

WORKDIR /app/apps/frontend

Suggested change

COPY apps/frontend/package.json apps/frontend/bun.lock ./apps/frontend/

COPY apps/frontend/package.json apps/frontend/bun.lock ./apps/frontend/

WORKDIR /app/apps/frontend

Copilot · 2025-11-27T03:58:40Z

.github/workflows/frontend_ci.yml

+      - name: Build and push
+        uses: docker/build-push-action@v4
+        with:
+          context: apps/frontend


The Docker build context is set to apps/frontend, but the Dockerfile copies files from apps/frontend/ within the container. This creates a mismatch where the Dockerfile expects to be run from the repository root, but the workflow sets the context to the apps/frontend directory.

This will cause the build to fail because paths like COPY apps/frontend/package.json won't work when the context is already apps/frontend.

Suggested fix: Either change the context to . (repository root):

context: . file: apps/frontend/Dockerfile

Or update the Dockerfile to work with apps/frontend as the context by removing the apps/frontend/ prefix from COPY commands.

Suggested change

context: apps/frontend

context: .

Copilot · 2025-11-27T03:58:41Z

.github/workflows/frontend_ci.yml

+        uses: aquasecurity/trivy-action@master
+        with:
+          image-ref: 'ghcr.io/${{ github.repository }}/frontend:latest'
+          format: 'table'
+          exit-code: '1'


The Trivy security scan on line 63 will attempt to scan an image that may not be publicly accessible from the GitHub Actions runner, since it was just pushed to GHCR. The scan should either:

Pull the image first after authenticating, or

Scan the local image before pushing, or

Include proper authentication for pulling from GHCR

Additionally, using @master for the action version is not a best practice as it can lead to unexpected breaking changes.

Suggested fix:

- name: Scan image uses: aquasecurity/trivy-action@0.17.0 # Use a specific version with: image-ref: 'ghcr.io/${{ github.repository }}/frontend:latest' format: 'sarif' output: 'trivy-results.sarif'

Suggested change

uses: aquasecurity/trivy-action@master

with:

image-ref: 'ghcr.io/${{ github.repository }}/frontend:latest'

format: 'table'

exit-code: '1'

uses: aquasecurity/trivy-action@0.17.0

with:

image-ref: 'ghcr.io/${{ github.repository }}/frontend:latest'

format: 'table'

exit-code: '1'

env:

TRIVY_USERNAME: ${{ github.actor }}

TRIVY_PASSWORD: ${{ secrets.GITHUB_TOKEN }}

Copilot · 2025-11-27T03:58:41Z

.github/workflows/backend_ci.yml

+      - name: Deploy to Railway
+        uses: railwayapp/cli-action@v1
+        with:
+          railway_token: ${{ secrets.RAILWAY_API_TOKEN }}


The Railway deployment step is missing critical information for a successful deployment. The railwayapp/cli-action@v1 requires additional parameters such as:

service: The service name to deploy

environment: The environment to deploy to (e.g., production, staging)

Without these parameters, the deployment may fail or deploy to an unintended target.

Suggested fix:

- name: Deploy to Railway uses: railwayapp/cli-action@v1 with: railway_token: ${{ secrets.RAILWAY_API_TOKEN }} service: backend environment: production

Suggested change

railway_token: ${{ secrets.RAILWAY_API_TOKEN }}

railway_token: ${{ secrets.RAILWAY_API_TOKEN }}

service: backend

environment: production

Copilot · 2025-11-27T03:58:41Z

.github/workflows/backend_ci.yml

+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main


[nitpick] The workflow uses push to main branch as a trigger (lines 5-7), which means every push to main will trigger build, push, and deploy. This could lead to unnecessary deployments if multiple commits are pushed quickly or if the deploy should only happen on releases.

Consider adding conditions to prevent deployment on every push:

on: push: branches: - main tags: - 'v*' # Deploy only on version tags pull_request: branches: - main jobs: # ... test and build jobs ... deploy: runs-on: ubuntu-latest needs: build_and_push if: github.event_name == 'push' && github.ref == 'refs/heads/main' # Only deploy on push to main, not PRs

adhit-r · 2025-11-28T02:39:20Z

@kishore8220 -> pls review

adhit-r · 2025-11-28T02:48:16Z

Hey! Thanks for the PR. I found a few issues that need fixing:

Main Issues:

Wrong frontend path - The workflows and Dockerfile reference apps/frontend but the actual frontend is in apps/frontend-new. This will cause the workflows to fail.
Duplicate workflows - We already have CI/CD workflows in .github/workflows/ci-cd.yml that do similar things. This might cause conflicts or duplicate runs.
Missing type-check script - The frontend workflow runs bun run type-check but that script doesn't exist in apps/frontend-new/package.json. The existing workflow uses bunx tsc --noEmit instead.
Backend should use uv - The backend workflow uses pip but we prefer uv for Python (see existing ci-cd.yml).
Outdated action versions - Using actions/checkout@v3 and setup-python@v4 while existing workflows use v4/v5.
Missing permissions - The workflows don't set proper permissions which might cause issues.
Dockerfile path issue - The frontend Dockerfile references apps/frontend which doesn't exist.

Suggestions:

Either update the paths to use apps/frontend-new or consolidate with the existing workflows
Use uv for backend instead of pip
Add proper permissions blocks
Update action versions to match existing workflows
Fill out the PR description template (it's currently empty)

lohaniprateek · 2025-11-28T03:35:04Z

I'll check that.

kishore8220 · 2025-12-02T05:11:33Z

The CI/CD pipeline implementation is well-structured and covers the necessary stages for build, test, and deployment. I appreciate the use of environment variables and the separation of concerns within the workflow files.
However, it would be beneficial to include more granular error handling, especially for deployment steps, to ensure easier debugging in case of failure. Please also consider adding caching for dependencies in the build stage to improve performance.
Lastly, a brief README update summarizing the workflow changes would help future contributors quickly understand the CI/CD process.

lohaniprateek and others added 4 commits August 30, 2025 12:56

empty commit

cdd1e74

Merge branch 'adhit-r:main' into main

dee20e2

feat: Implement comprehensive CI/CD pipeline for backend and frontend

033ab84

Merge branch 'adhit-r:main' into main

49204c9

adhit-r requested review from 27804balaji, Copilot and kishore8220 November 27, 2025 03:53

Copilot started reviewing on behalf of adhit-r November 27, 2025 03:53 View session

Copilot finished reviewing on behalf of adhit-r November 27, 2025 03:56

Copilot AI reviewed Nov 27, 2025

View reviewed changes

	# Build the Next.js application
	# Build the Next.js application
	WORKDIR /app/apps/frontend

	COPY apps/frontend/package.json apps/frontend/bun.lock ./apps/frontend/
	COPY apps/frontend/package.json apps/frontend/bun.lock ./apps/frontend/
	WORKDIR /app/apps/frontend

CI-CD this closes #26 #141

Are you sure you want to change the base?

CI-CD this closes #26 #141

Uh oh!

Conversation

lohaniprateek commented Nov 23, 2025 • edited by 27804balaji Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

🔗 Related Issue

🎯 Type of Change

🧪 Testing

📸 Screenshots (if applicable)

✅ Checklist

🔍 Review Notes

📚 Additional Context

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

adhit-r commented Nov 28, 2025

Uh oh!

adhit-r commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lohaniprateek commented Nov 28, 2025

Uh oh!

kishore8220 commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lohaniprateek commented Nov 23, 2025 •

edited by 27804balaji

Loading

adhit-r commented Nov 28, 2025 •

edited

Loading