Merge pull request #8 from chronotc/escape-characters

handle quotes and newline in commit messages

lib/trigger.bash

@@ -78,8 +78,9 @@ function add_build_commit() {
 function add_build_message() {
   local build_message=$1
   default_message="${BUILDKITE_MESSAGE:-}"
+  sanitized_build_message=$(sanitize_string "${build_message:-$default_message}")
 
-  pipeline_yml+=("      message: \"${build_message:-$default_message}\"")
+  pipeline_yml+=("      message: \"$sanitized_build_message\"")
 }
 
 function add_build_branch() {
@@ -130,3 +131,9 @@ function add_hooks() {
     add_command "$command"
   done <<< "$(plugin_read_list HOOKS COMMAND)"
 }
+
+function sanitize_string() {
+  local string=$1
+  escaped_quotes="${string//\"/\\\"}"
+  echo "$escaped_quotes"
+}

tests/trigger.bats

@@ -245,3 +245,20 @@ load '/usr/local/lib/bats/load.bash'
   assert_output --partial "  - command: echo test"
   assert_output --partial "  - command: aws s3 ls"
 }
+
+@test "Preserves quotes in commit messages" {
+  export BUILDKITE_MESSAGE="Hello world \"stuff\" \n multiline"
+  export BUILDKITE_PLUGIN_MONOREPO_DIFF_DIFF="cat $PWD/tests/mocks/diff1"
+  export BUILDKITE_PLUGIN_MONOREPO_DIFF_WATCH_0_PATH="services/foo"
+  export BUILDKITE_PLUGIN_MONOREPO_DIFF_WATCH_0_CONFIG_TRIGGER="slug-for-foo"
+  export DEBUG=true
+
+  stub buildkite-agent \
+    "pipeline upload : echo uploading"
+
+  run $PWD/hooks/command
+
+  unstub buildkite-agent
+  assert_success
+  assert_output --partial '    message: "Hello world \"stuff\" \n multiline"'
+}