Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable checks for canopen #36

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

urob
Copy link
Contributor

@urob urob commented Jan 21, 2025

This disables checks for canopen, which fail on aarch64-darwin. Without having dug deeper, the FIXME comment in the error message suggests that they fail due to fragile timing assumptions in the tests rather than for substantive reasons.

error: builder for '/nix/store/7c35wjdq8qkbms76scqxcsv5ci16fis0-python3.12-canopen-2.3.0.drv' failed with exit code 1;
       last 25 log lines:
       > =================================== FAILURES ===================================
       > ________________________ TestNetwork.test_send_perodic _________________________
       >
       > self = <test_network.TestNetwork testMethod=test_send_perodic>
       >
       >     def test_send_perodic(self):
       >         bus = can.interface.Bus(bustype="virtual", channel=1)
       >         self.network.connect(bustype="virtual", channel=1)
       >
       >         task = self.network.send_periodic(0x123, [1, 2, 3], 0.01)
       >         time.sleep(0.1)
       >         # FIXME: This test is a little fragile, as the number of elements
       >         #        depends on the timing of the machine.
       >         print(f"Queue size: {bus.queue.qsize()}")
       > >       self.assertTrue(9 <= bus.queue.qsize() <= 13)
       > E       AssertionError: False is not true
       >
       > test/test_network.py:65: AssertionError
       > ----------------------------- Captured stdout call -----------------------------
       > Queue size: 18
       > ------------------------------ Captured log call -------------------------------
       > WARNING  canopen.objectdictionary.eds:eds.py:270 Complex data type has an unknown or unsupported data type (0x40)
       > =========================== short test summary info ============================
       > FAILED test/test_network.py::TestNetwork::test_send_perodic - AssertionError: False is not true
       > ======================== 1 failed, 119 passed in 13.31s ========================
       For full logs, run 'nix log /nix/store/7c35wjdq8qkbms76scqxcsv5ci16fis0-python3.12-canopen-2.3.0.drv'.
error: 1 dependencies of derivation '/nix/store/qmfyyggz2zad89g05hvqpj77s6dhcwsa-python3-3.12.8-env.drv' failed to build

@adisbladis adisbladis merged commit 8926125 into adisbladis:master Jan 21, 2025
4 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants