Update CHANGELOG.md #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admlvntv
requested changes
Mar 23, 2022
There was a problem hiding this comment.
Hey there 👋, thanks for the contribution! Just a few remarks. First off, I'm not fully sure the purpose of this change. It just looks like a duplicate of the above code. Can you explain why this needs to be added? Also, can you change your branch name to fit with the guidelines in the Getting Started section of the contributing guidelines? Also, can you please add a description to this PR in your description?
Comment on lines
+10
to
+15
|
|
||
|
|
||
| ### Added | ||
| - Added current weather support | ||
| - Added location information support |
There was a problem hiding this comment.
this seems to be just a duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check out the detailed analysis on softacheck