adds mesh retry async using child process #5
Conversation
src/commands/commerce/init.js
Outdated
| // TODO: Replace with detached childProcess. | ||
| if (shouldCreateMesh) { | ||
| await checkAndRetryMeshUpdate(runAIOCommand) | ||
| // Spawn detached child process to verify mesh in the background, without disrupting user's CLI session. |
There was a problem hiding this comment.
So this will kick off a detached child process and will log to mesh-verify.log. I'm a little concerned that it could fail and the user would not know. Based on my findings in node docs, If we want the parent process to exit before this, we cannot log to the terminal.
Perhaps we should add a log here, before we kick off the command, like Verifying Mesh Creation. Please check mesh-verify.log for details, or run "aio commerce:mesh-verify" if there are failures.
There was a problem hiding this comment.
And actually, I don't think this is working. When I run through the CLI for the first time, and select my project/workspace and "use for future operations", the mesh-verify command is still asking for user to select project/workspace.
There was a problem hiding this comment.
Yeah probably because you cleared the config.console. Ideally that shouldn't be the case. Ill verify it.
There was a problem hiding this comment.
I did not though - unless I missed it programatically. I ran the cli, which would have had it set after picking mesh, and then immediately after, the mesh-verify command runs.
There was a problem hiding this comment.
Fixed the mesh-verify issue in the past few commits. Also with d2e06e1 we can run mesh-verify command with few optional flags like this aio commerce mesh-verify --orgId 233240 --projectId 4566206088344816749 --workspaceId 4566206088344817114
sirugh
force-pushed
the
mesh-async-retry
branch
from
08c13ab to
01a7eb2
Compare
…patibility and instructions for setting up cli Signed-off-by: Stephen Rugh <rugh@adobe.com>
sirugh
force-pushed
the
mesh-async-retry
branch
from
01a7eb2 to
558f848
Compare
Signed-off-by: Stephen Rugh <rugh@adobe.com>
2 participants
❗ DO NOT MERGE ❗
Retry logic.
Pausing for now. We were stuck as for some reason the workspace is being deleted so the retry script was failing.
We will instead add output instructions to guide users in event of mesh provision failure.