Update ClientTest.cc #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems that `ASSERT_*` versions are more appropriate than `EXPECT_* here, given the following Google Test guideline: - "ASSERT_* versions generate fatal failures when they fail, and abort the current function. EXPECT_* versions generate nonfatal failures, which don't abort the current function. Usually EXPECT_* are preferred, as they allow more than one failures to be reported in a test. However, you should use ASSERT_* if it doesn't make sense to continue when the assertion in question fails." Source: https://code.google.com/p/googletest/wiki/Primer#Assertions This replaces `EXPECT_*` with `ASSERT_*` in the context where continuing would lead to dereferencing a null pointer -- which is undefined behavior: https://stackoverflow.com/questions/6793262/why-dereferencing-a-null-pointer-is-undefined-behaviour
Amending w/ one more null-ptr-dereference fix.
|
This (i.e., commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that
ASSERT_*versions are more appropriate thanEXPECT_*here, given the following Google Test guideline:ASSERT_*versions generate fatal failures when they fail, and abort the current function.EXPECT_*versions generate nonfatal failures, which don't abort the current function. UsuallyEXPECT_*are preferred, as they allow more than one failures to be reported in a test. However, you should useASSERT_*if it doesn't make sense to continue when the assertion in question fails."Source: https://code.google.com/p/googletest/wiki/Primer#Assertions
This replaces
EXPECT_*withASSERT_*in the contexts where attempting to continue results in dereferencing a null pointer -- which is undefined behavior: https://stackoverflow.com/questions/6793262/why-dereferencing-a-null-pointer-is-undefined-behaviour