Implement GetBucketCors, PutBucketCors, DeleteBucketCors APIs by Copilot · Pull Request #2993 · adobe/S3Mock

Copilot · 2026-03-16T20:49:34Z

S3Mock had no support for the bucket CORS configuration APIs (GetBucketCors, PutBucketCors, DeleteBucketCors). This adds full lifecycle management of bucket CORS configuration, following the same pattern as BucketLifecycleConfiguration.

DTO

New CorsConfiguration and CorsRule data classes with Jackson XML annotations matching the AWS CORSConfiguration schema

Storage

BucketMetadata gains corsConfiguration: CorsConfiguration? = null — default null preserves backward compatibility with existing serialized metadata
BucketStore.storeBucketCorsConfiguration() persists the config

Service & Controller

BucketService: get/set/deleteBucketCorsConfiguration(), throws NO_SUCH_CORS_CONFIGURATION (404) when absent
BucketController: three new endpoints — GET, PUT, DELETE on /{bucket}?cors
AwsHttpParameters: CORS / NOT_CORS constants added; createBucket, deleteBucket, and listObjects updated with NOT_CORS to avoid routing ambiguity

Tests

Unit tests in BucketServiceTest and BucketControllerTest covering put/get/delete and the absent-config error case
Integration tests in BucketIT covering the full put → get → delete → verify-gone flow

// SDK v2 usage now works against S3Mock
s3Client.putBucketCors {
    it.bucket(bucketName)
    it.corsConfiguration(CORSConfiguration.builder()
        .corsRules(CORSRule.builder()
            .allowedMethods("GET", "PUT")
            .allowedOrigins("http://www.example.com")
            .maxAgeSeconds(3000)
            .build())
        .build())
}
s3Client.getBucketCors { it.bucket(bucketName) }
s3Client.deleteBucketCors { it.bucket(bucketName) }

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher compile -pl server -q (dns block)
- Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher compile -pl server -q (dns block)
- Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher test -pl server -q --no-transfer-progress (dns block)
maven.java.net
- Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher compile -pl server -q (dns block)
- Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher test -pl server -q --no-transfer-progress (dns block)
- Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher test -pl server -q --no-transfer-progress -Dtest=BucketMetadataTest,BucketServiceTest,BucketControllerTest,BucketStoreTest (dns block)
repository.apache.org
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher compile -pl server -q (dns block)
- Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher compile -pl server -q (dns block)
- Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher test -pl server -q --no-transfer-progress (dns block)
repository.sonatype.org
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher compile -pl server -q (dns block)
- Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher compile -pl server -q (dns block)
- Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591 -Dmaven.mainClass=org.apache.maven.cling.MavenCling -Dlibrary.jline.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-4.0.0-rc-5/1d86e591/lib/jline-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/S3Mock/S3Mock org.codehaus.plexus.classworlds.launcher.Launcher test -pl server -q --no-transfer-progress (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Implement delete bucket cors api

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: afranken <763000+afranken@users.noreply.github.com>

Copilot

Pull request overview

Adds S3 bucket CORS subresource support to S3Mock by introducing CORS DTOs, persisting CORS configuration in bucket metadata, and exposing GetBucketCors, PutBucketCors, and DeleteBucketCors endpoints consistent with existing lifecycle configuration patterns.

Changes:

Introduce CorsConfiguration / CorsRule DTOs with XML annotations matching AWS schema.
Persist optional bucket CORS configuration in BucketMetadata, add store/service/controller lifecycle methods, and add routing guards (CORS / NOT_CORS) to avoid endpoint ambiguity.
Add unit + integration tests and update docs/changelog to reflect new API support.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
server/src/main/kotlin/com/adobe/testing/s3mock/dto/CorsConfiguration.kt	New DTOs for CORS configuration and rules with AWS-compatible XML annotations.
server/src/main/kotlin/com/adobe/testing/s3mock/store/BucketMetadata.kt	Add `corsConfiguration` to persisted bucket metadata plus helper copy method.
server/src/main/kotlin/com/adobe/testing/s3mock/store/BucketStore.kt	Persist CORS configuration changes to disk under bucket lock.
server/src/main/kotlin/com/adobe/testing/s3mock/service/BucketService.kt	Add get/set/delete CORS configuration service methods and 404 when absent.
server/src/main/kotlin/com/adobe/testing/s3mock/controller/BucketController.kt	Add GET/PUT/DELETE `?cors` endpoints and routing exclusions to avoid ambiguity.
server/src/main/kotlin/com/adobe/testing/s3mock/util/AwsHttpParameters.kt	Add `CORS` / `NOT_CORS` query-param constants for request mapping disambiguation.
server/src/main/kotlin/com/adobe/testing/s3mock/S3Exception.kt	Add `NO_SUCH_CORS_CONFIGURATION` mapped to 404 / `NoSuchCORSConfiguration`.
server/src/test/kotlin/com/adobe/testing/s3mock/service/BucketServiceTest.kt	Add unit test coverage for CORS configuration lifecycle in service layer.
server/src/test/kotlin/com/adobe/testing/s3mock/controller/BucketControllerTest.kt	Add controller tests for put/get/delete bucket CORS endpoints.
server/src/test/resources/com/adobe/testing/s3mock/store/BucketMetadataTest_testSerialization.json	Update expected serialized metadata to include `corsConfiguration: null`.
integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/BucketIT.kt	Add integration tests for full put→get→delete CORS lifecycle and error when absent.
README.md	Mark CORS APIs as supported in operations table.
CHANGELOG.md	Document new CORS API support under 5.0.0 features/fixes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

server/src/test/kotlin/com/adobe/testing/s3mock/service/BucketServiceTest.kt

+    val bucketName = "bucket-cors"
+    val bucketMetadata = givenBucket(bucketName)
+
+    // Absent -> throws
+    assertThatThrownBy { iut.getBucketCorsConfiguration(bucketName) }
+      .isEqualTo(S3Exception.NO_SUCH_CORS_CONFIGURATION)
+
+    // Set CORS configuration
+    val cors = CorsConfiguration(listOf(CorsRule(null, listOf("GET"), listOf("*"), null, null, null)))
+    iut.setBucketCorsConfiguration(bucketName, cors)
+
+    // Simulate store returning updated metadata
+    whenever(bucketStore.getBucketMetadata(bucketName)).thenReturn(
+      bucketMetadata(
+        bucketName,
+        bucketMetadata,
+        corsConfiguration = cors,
+      )


Initial plan

3da8b9e

Copilot AI assigned Copilot and afranken Mar 16, 2026

Copilot started work on behalf of afranken March 16, 2026 20:49 View session

Copilot AI and others added 2 commits March 16, 2026 21:07

Implement delete/get/put bucket CORS API

f23e4c2

Co-authored-by: afranken <763000+afranken@users.noreply.github.com>

Fix review comments: error message period and changelog placeholder

27cf319

Co-authored-by: afranken <763000+afranken@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add delete bucket CORS API~~ Implement GetBucketCors, PutBucketCors, DeleteBucketCors APIs Mar 16, 2026

Copilot AI requested a review from afranken March 16, 2026 21:09

Copilot finished work on behalf of afranken March 16, 2026 21:09

afranken marked this pull request as ready for review March 16, 2026 21:13

Copilot AI review requested due to automatic review settings March 16, 2026 21:13

Copilot started reviewing on behalf of afranken March 16, 2026 21:14 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement GetBucketCors, PutBucketCors, DeleteBucketCors APIs#2993

Implement GetBucketCors, PutBucketCors, DeleteBucketCors APIs#2993
Copilot wants to merge 3 commits intomainfrom
copilot/implement-delete-bucket-cors-api

Copilot AI commented Mar 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DTO

Storage

Service & Controller

Tests

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 16, 2026 •

edited

Loading