FORMS-14068: Enable rule-editor spa in core-components #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1427 +/- ##
=========================================
Coverage 82.40% 82.40%
Complexity 919 919
=========================================
Files 103 103
Lines 2358 2358
Branches 317 317
=========================================
Hits 1943 1943
Misses 255 255
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rismehta
reviewed
Sep 30, 2024
| @@ -32,22 +32,93 @@ | |||
| ruleEditorFrame.setAttribute('id','af-rule-editor'); | |||
| let formContainerPath = getFormContainerPath(editable); | |||
| if (!formContainerPath) { | |||
| showAlert(); | |||
| if (Granite.Toggles.isEnabled("FT_FORMS-14068")) { | |||
There was a problem hiding this comment.
Core components should not reference any toggle API; ideally, this code should reside in cq-guides, and we should simply reference it here. Customers won't customize this behavior.
There was a problem hiding this comment.
I found two instances of using toggles in core component:
-
Granite:
-
toggles.json api:
can we use api call approach or go with cq-guides only?
There was a problem hiding this comment.
this is old code which was moved long back from cq-guides to core components, I would prefer the current changes to move to cq-guides. It would be dependent on FAR changes if you move to cq-guides
github-actions
bot
force-pushed
the
FORMS-14068
branch
from
00a4eb9 to
c79bd69
Compare
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
* Added new HTML types to field types * Adding hidden fieldtype * updated spec version
…date time picker widget (#1432) * FORMS-16264: Fixed test cases * FORMS-16264: Remove same instantiation of datetimepicker calendar element * FORMS-16264: Resolve conflict
rismehta
requested changes
Oct 4, 2024
| if (typeof window.CQ.FormsCoreComponents.editorhooks.v2.openRuleEditor === 'function') { | ||
| window.CQ.FormsCoreComponents.editorhooks.v2.openRuleEditor(editable); | ||
| } else { | ||
| let ruleEditorUri = '/aem/af/expeditor.html' + getFormContainerPath(editable) + "?fieldPath=" + editable.path + "&fieldId=" + getFieldId(editable); |
There was a problem hiding this comment.
This can be done like this,
const ruleEditorUri = `/aem/af/expeditor.html${getFormContainerPath(editable)}?fieldPath=${editable.path}&fieldId=${getFieldId(editable)}`;
ruleEditorFrame.setAttribute('src', ruleEditorUri);
ruleEditorFrame.setAttribute('title', 'AF Rule Editor');
const styles = {
display: "block",
width: "100%",
height: "100%",
top: "0",
left: "0",
position: "fixed",
zIndex: "10"
};
Object.assign(ruleEditorFrame.style, styles);
document.body.appendChild(ruleEditorFrame);
| @@ -19,6 +19,7 @@ | |||
| window.CQ = window.CQ || {}; | |||
| window.CQ.FormsCoreComponents = window.CQ.FormsCoreComponents || {}; | |||
| window.CQ.FormsCoreComponents.editorhooks = window.CQ.FormsCoreComponents.editorhooks || {}; | |||
| window.CQ.FormsCoreComponents.editorhooks.v2 = window.CQ.FormsCoreComponents.editorhooks.v2 || {}; | |||
There was a problem hiding this comment.
Let's not add v2, it does not make sense
added 8 commits
October 8, 2024 12:32
|
Creating new PR, as this is not rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: