-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SITES-22935 NGDM remote image issue #2792
base: main
Are you sure you want to change the base?
Conversation
Make changes work for multiple fileupload instances present in a custom multifield component.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2792 +/- ##
=========================================
Coverage 87.21% 87.21%
Complexity 2687 2687
=========================================
Files 235 235
Lines 7170 7170
Branches 1096 1096
=========================================
Hits 6253 6253
Misses 363 363
Partials 554 554 ☔ View full report in Codecov by Sentry. |
...t/src/content/jcr_root/apps/core/wcm/components/image/v3/image/clientlibs/editor/js/image.js
Outdated
Show resolved
Hide resolved
...t/src/content/jcr_root/apps/core/wcm/components/image/v3/image/clientlibs/editor/js/image.js
Outdated
Show resolved
Hide resolved
Incorporate review comments.
@mohiaror , could you please add UI test for this fix? |
@mohiaror Changes that I applied was regarding page properties image section |
Incorporate changes done in other PR - b5e6a56
Quality Gate passedIssues Measures |
Make changes work for multiple fileupload instances present in a custom multifield component.
Fixes #1, Fixes #2