Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm lint to ui.tests maven build #1184

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Add npm lint to ui.tests maven build #1184

merged 1 commit into from
Apr 9, 2024

Conversation

dulvac
Copy link
Member

@dulvac dulvac commented Apr 8, 2024

Description

Add a npm lint to the maven build for the wdio and cypress ui.tests modules.

Related Issue

This fixes #1173

Motivation and Context

This is useful for catching syntax and linting errors when doing a local maven build, instead of waiting for a CS pipeline deployment.

How Has This Been Tested?

Tested locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@bisswanger bisswanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and linting passes locally for both Cypress and Selenium

@dulvac dulvac merged commit f97b5e8 into develop Apr 9, 2024
10 checks passed
@dulvac dulvac deleted the adulvac-lint branch April 9, 2024 07:10
@pankaj-parashar pankaj-parashar added this to the 49 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce local build of ui-tests module by default
3 participants