Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-3467 - set npm engine in package.json for dependabot #99

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

amulyakashyap09
Copy link
Contributor

@amulyakashyap09 amulyakashyap09 commented Jan 23, 2025

Description

Set npm engine in package.json for dependabot

Getting this issue now : Dependabot does not support your npm version. Because of this, Dependabot cannot update this pull request.
Due to Dependabot will no longer support npm v6https://github.blog/changelog/2025-01-20-dependabot-will-no-longer-support-npm-v6/#:~:text=If%20you%20continue%20to%20use,is%20the%20newest%20supported%20release.We need to upgrade npm.

Related Issue

ACNA-3467

Motivation and Context

How Has This Been Tested?

  • npm install && npm run posttest && npm test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2988b81) to head (9b7ebbb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #99   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          730       730           
  Branches       104       104           
=========================================
  Hits           730       730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amulyakashyap09 amulyakashyap09 changed the title ACNA-3467 | Update all deps ACNA-3467 | Set npm engine in package.json for dependabot Jan 23, 2025
@amulyakashyap09 amulyakashyap09 changed the title ACNA-3467 | Set npm engine in package.json for dependabot Set npm engine in package.json for dependabot Jan 23, 2025
@amulyakashyap09 amulyakashyap09 changed the title Set npm engine in package.json for dependabot fix: set npm engine in package.json for dependabot Jan 23, 2025
@shazron shazron changed the title fix: set npm engine in package.json for dependabot fix: ACNA-3467 - set npm engine in package.json for dependabot Jan 23, 2025
@shazron shazron merged commit 9494ccb into master Jan 23, 2025
10 checks passed
@shazron shazron deleted the update-all-deps branch January 23, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants