-
Notifications
You must be signed in to change notification settings - Fork 31
ACNA-3274 | point runtime plugin to deploy service #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACNA-3274 | point runtime plugin to deploy service #360
Conversation
… acna-3274-point-runtime-plugin-to-deploy-service
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 66 66
Lines 1745 1758 +13
Branches 369 371 +2
=========================================
+ Hits 1745 1758 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please do not merge this PR , before merging Production URL Needs to be updated. |
shazron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- needs adobe/aio-lib-runtime#206 to be merged released before this is merged, add to description
- affirm that testing this works with the dev deployservice (via the apihost env var)
|

Description
NOTE
Related Issue
ACNA-3274
ACNA-3602
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Feature Flag Enabled: Should give 200 with IS_DEPLOY_SERVICE_ENABLED = true
Feature Flag Disabled: Should give 401 with IS_DEPLOY_SERVICE_ENABLED = false [as ow auth_handler will not be available]
Types of changes
Checklist: