Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oak index configuration optimizations #1217

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

davidjgonzalez
Copy link
Contributor

@davidjgonzalez davidjgonzalez commented Jan 23, 2025

Description

Add support for QueryBuilder p.facetStrategy and p.indexTag predicates that allow for more performant queries.
Also, addresses issue with FastProperties index resolution sometimes not working.

2025-01-23 at 1 35 PM

Debug logs of QueryBuilder query being executed

DEBUG com.adobe.aem.commons.assetshare.search.providers.impl.QuerySearchProviderImpl

Query Builder Parameters: 23_group.0_path = /content/dam/asset-share-commons/en/public | 23_group.p.or = true | 25_group.mainasset = true | 26_group.property = jcr:content/contentFragment | 26_group.property.operation = not | orderby = @jcr:content/jcr:lastModified | orderby.sort = desc | p.facetStrategy = oak | p.guessTotal = 100 | p.indexTag = shared-assets | p.limit = 24 | p.offset = 0 | type = dam:Asset |

QB Docs: https://experienceleague.adobe.com/en/docs/experience-manager-cloud-service/content/implementing/developing/full-stack/search/query-builder-predicates

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 8.33333% with 33 lines in your changes missing coverage. Please review.

Project coverage is 28.01%. Comparing base (d29cbf7) to head (0870445).
Report is 28 commits behind head on develop.

Files with missing lines Patch % Lines
.../components/predicates/impl/PagePredicateImpl.java 0.00% 18 Missing ⚠️
...share/components/search/impl/SearchConfigImpl.java 0.00% 10 Missing ⚠️
...ssetshare/components/predicates/PagePredicate.java 0.00% 3 Missing ⚠️
...ons/assetshare/components/search/SearchConfig.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1217      +/-   ##
=============================================
- Coverage      28.19%   28.01%   -0.18%     
- Complexity       552      553       +1     
=============================================
  Files            182      182              
  Lines           4738     4772      +34     
  Branches         673      680       +7     
=============================================
+ Hits            1336     1337       +1     
- Misses          3213     3246      +33     
  Partials         189      189              
Flag Coverage Δ
unittests 28.01% <8.33%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidjgonzalez davidjgonzalez merged commit 3ed3d6b into develop Jan 24, 2025
5 of 7 checks passed
@davidjgonzalez davidjgonzalez deleted the oak-index-optimizations branch January 24, 2025 13:23
@davidjgonzalez davidjgonzalez added this to the 3.9.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant