Skip to content

Conversation

@SarikaVanapalli
Copy link
Collaborator

@SarikaVanapalli SarikaVanapalli commented Oct 6, 2025

Description

Added a new viewId field to the existing storefrontInstance schema and context to support the new catalog view id. A new version of DS is available in snowplow to support it, so the packages are updated to match the same.
Link to snowplow schema -> HERE

Related Issue

https://jira.corp.adobe.com/browse/COMOPT-1216
https://jira.corp.adobe.com/browse/COMOPT-1217

Motivation and Context

How Has This Been Tested?

Verified that all existing unit tests pass with no issues when the new viewId is included. The new field is made optional, so no existing flows will break.

Screenshots (if appropriate): N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@benjaminkalk benjaminkalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the documentation as well to reflect changes and include some information on when and what values need to be populated for the different environments?
Also, if we are no longer planning on requiring storeCode and storeViewCode. Could you also remove the warnings of that impending requirement?
https://github.com/adobe/commerce-events/blob/main/examples/events/snowplow-debugger/storefront-instance.json
https://github.com/adobe/commerce-events/blob/main/examples/events/example-contexts/mock-storefront-context.md
https://github.com/adobe/commerce-events/blob/main/examples/events/readme.md

@SarikaVanapalli
Copy link
Collaborator Author

@benjaminkalk I addressed all requested changes, can you take a look?

@SarikaVanapalli SarikaVanapalli merged commit c874e3f into main Oct 9, 2025
3 checks passed
@SarikaVanapalli SarikaVanapalli deleted the feature/update-viewId-sdk-collector branch October 9, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants