fix: flaky test (#117)

adobe · Oct 7, 2024 · 9562d99 · 9562d99
1 parent 4989d47
commit 9562d99
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/.github/workflows/run-tests.yaml b/.github/workflows/run-tests.yaml
@@ -19,6 +19,10 @@ jobs:
       env:
         CI: true
     - name: Upload coverage reports to Codecov
-      uses: codecov/codecov-action@v3
+      uses: codecov/codecov-action@v4
+      env:
+        CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
       with: 
-        files: ./coverage/lcov.info
+        fail_ci_if_error: true
+        files: ./coverage/lcov.info
+        verbose: true
diff --git a/test/components/block-renderer/block-renderer.test.js b/test/components/block-renderer/block-renderer.test.js
@@ -402,9 +402,7 @@ describe('BlockRenderer', () => {
       const img = cardsBlock.querySelector('img');
       img.src = IMAGE;
       await aTimeout(1000);
-      const wrapper = blockRenderer.getBlockWrapper();
-      const modifiedBlock = wrapper.querySelector('.cards');
-      expect(modifiedBlock.querySelector('img').src).to.equal(IMAGE);
+      expect(cardsBlock.querySelector('img').src).to.equal(IMAGE);
     });
 
     describe('enableImageDragDrop', () => {
@@ -420,6 +418,7 @@ describe('BlockRenderer', () => {
         const cardsBlock = recursiveQuery(iframe.contentDocument, '.cards');
         expect(cardsBlock).to.exist;
 
+        await aTimeout(1000);
         const img = cardsBlock.querySelector('img');
         img.dispatchEvent(new Event('dragover', { target: img }));
         expect(img.style.outline).to.equal('rgb(84, 163, 246) solid 4px');