Skip to content

Conversation

@purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Apr 23, 2025

Description

This does a few things all at once ...

  • update dependencies on other templates ( they have wskdebug removed now )
  • adds support for typescript, no code in here is actually ts, but the config/tooling is there and ready
  • debugging is also enabled via a webpack config that specifies sourcemaps, otherwise breakpoints don't work
  • re-ordered linting+unittests otherwise it is impossible to do focused tests

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (420490d) to head (576cdba).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #281   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          205       207    +2     
  Branches        24        24           
=========================================
+ Hits           205       207    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@purplecabbage purplecabbage merged commit 352361b into master May 1, 2025
10 checks passed
@purplecabbage purplecabbage deleted the VSCodeLaunch branch May 1, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants