Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allowing BC era timestamps in fromAbsolute (#6541) #6542

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

KimPeeters
Copy link
Contributor

@KimPeeters KimPeeters commented Jun 13, 2024

Closes #6541

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

The unit test should cover this. By hand:

import { fromAbsolute } from "@internationalized/date";

console.log(fromAbsolute(-62135596800001, "UTC").toAbsoluteString());
// ^^ should return:  0000-12-31T23:59:59.999Z

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, will get other reviews

@snowystinger snowystinger changed the title Allowing BC era timestamps in fromAbsolute (#6541) fix: Allowing BC era timestamps in fromAbsolute (#6541) Oct 23, 2024
@yihuiliao yihuiliao added this pull request to the merge queue Nov 13, 2024
Merged via the queue into adobe:main with commit 3949762 Nov 13, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fromAbsolute in @internalization/date parses dates BC incorrectly
3 participants