fix(site): update Next.js basePath to spectrum-design-data#634
Merged
Conversation
The critical config change from PR #633 was missed. This updates the production asset paths to fix font loading on GitHub Pages.
|
Member
Author
Run report for 7bf4c37eTotal time: 25.1s | Comparison time: 23.8s | Estimated loss: 1.3s (5.2% slower)
Touched files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the ACTUAL fix that was meant to be in PR #633 but was accidentally omitted.
The critical
next.config.jschange was left uncommitted when #633 was created, so the site is still loading assets from/spectrum-tokens/paths, causing fonts and other assets to fail.Changes
basePathfrom/spectrum-tokensto/spectrum-design-dataassetPrefixfrom/spectrum-tokens/to/spectrum-design-data/What Happened
PR #633 successfully merged:
package.jsonrepository URL updatesnext.config.jschanges (accidentally left uncommitted)This PR contains only the missing config file change.
After Merge
The site will rebuild and fonts/assets will load correctly at:
Related: #633