Conversation
…atter Made-with: Cursor
Tokens with sets whose aliases chain through other set-based tokens (e.g. accent-background-color-default -> accent-color-900 -> blue-900) were producing nested objects that rendered as [object Object]. Fixed the resolver to flatten nested sets and the display formatters to handle objects and arrays (drop shadows, typography composites) gracefully. Added regression test asserting no generated markdown contains [object Object]. Made-with: Cursor
|
Member
Author
Run report for d93b6915Total time: 47.5s | Comparison time: 47.8s | Estimated savings: 337.4ms (0.7% faster)
Touched files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source_urlto generated markdown frontmatter so each token/component/registry page links back to its published URL onopensource.adobe.com[object Object]rendering in generated token markdown tables (affected ~80+ tokens across color-aliases, typography, and other token files)accent-background-color-default->accent-color-900->blue-900) now correctly flatten to scalarrgb(...)values per set0px 2px 8px 0px ...) instead of[object Object],[object Object],...fontFamily,fontSize, etc.) now render as readable key-value strings[object Object]Test plan
pnpm exec ava tools/markdown-generator/test/**/*.test.js)generateTokenMarkdown never outputs [object Object] in token tablesgetTokenDisplayInfo resolves nested sets to scalar values per setdocs/markdown/output after runningmoon run markdown-generator:generate[object Object]on token pagesMade with Cursor