Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated badge fixed values #4742

Merged

Conversation

rubencarvalho
Copy link
Collaborator

Description

Removed the sp-badge non-logical fixed property values along with all associated references and dependencies.

Related issue(s)

Motivation and context

For the upcoming 1.0.0 release of Spectrum Web Components, we will remove the deprecated components and features.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@rubencarvalho rubencarvalho marked this pull request as ready for review September 11, 2024 12:57
@rubencarvalho rubencarvalho requested a review from a team as a code owner September 11, 2024 12:57
Copy link

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Copy link

github-actions bot commented Sep 11, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 228.586 kB 217.218 kB 🏆 217.432 kB
Scripts 57.947 kB 52.631 kB 🏆 52.781 kB
Stylesheet 34.578 kB 30.124 kB 🏆 30.187 kB
Document 6.239 kB 5.495 kB 5.482 kB 🏆
Font 126.87 kB 126.594 kB 🏆 126.631 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

Copy link

github-actions bot commented Sep 11, 2024

Tachometer results

Chrome

badge permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 24.16ms - 25.54ms - unsure 🔍
-8% - +3%
-1.96ms - +0.68ms
branch 389 kB 24.37ms - 26.62ms unsure 🔍
-3% - +8%
-0.68ms - +1.96ms
-
Firefox

badge permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 51.91ms - 56.29ms - unsure 🔍
-11% - -0%
-6.59ms - +0.07ms
branch 389 kB 54.85ms - 59.87ms unsure 🔍
-0% - +12%
-0.07ms - +6.59ms
-

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10812123757

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.205%

Totals Coverage Status
Change from base Build 10808456663: 0.0%
Covered Lines: 32500
Relevant Lines: 32931

💛 - Coveralls

@rubencarvalho rubencarvalho marked this pull request as draft September 24, 2024 11:24
@rubencarvalho rubencarvalho marked this pull request as ready for review October 15, 2024 12:19
@rubencarvalho rubencarvalho changed the base branch from main to ruben/remove-deprecations October 15, 2024 12:19
@rubencarvalho rubencarvalho added 1.0.0 Issues that should be addressed for a 1.0 release! Breaking labels Oct 15, 2024
Copy link
Contributor

@Rajdeepc Rajdeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge with the ruben/remove-deprecations branch and then we are good to land!

@rubencarvalho rubencarvalho merged commit 5e7a374 into ruben/remove-deprecations Oct 16, 2024
55 of 57 checks passed
@rubencarvalho rubencarvalho deleted the ruben/remove-badge-deprecations branch October 16, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 Issues that should be addressed for a 1.0 release! Breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants