chore: remove 'theme' attribute from sp-theme #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
rubencarvalho
changed the base branch from
main
to
ruben/remove-deprecations
Pull Request Test Coverage Report for Build 10906755209Details
💛 - Coveralls |
Tachometer resultsChromeaccordion permalinkbasic-test
action-bar permalinkbasic-test
action-button permalinkbasic-test
action-group permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
alert-banner permalinkbasic-test
alert-dialog permalinkbasic-test
asset permalinkbasic-test
avatar permalinktest-basic
badge permalinkbasic-test
breadcrumbs permalinkbasic-test
button-group permalinkbasic-test
button permalinktest-basic
card permalinktest-basic
checkbox permalinktest-basic
coachmark permalinkbasic-test
color-area permalinkbasic-test
color-field permalinkbasic-test
color-handle permalinkbasic-test
color-loupe permalinkbasic-test
color-slider permalinkbasic-test
color-wheel permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
contextual-help permalinkbasic-test
dialog permalinkbasic-test
divider permalinkbasic-test
dropzone permalinktest-basic
field-group permalinkbasic-test
field-label permalinkbasic-test
grid permalinkbasic-test
help-text permalinkbasic-test
icon permalinktest-basic
icons permalinktest-basic
illustrated-message permalinktest-basic
infield-button permalinkbasic-test
link permalinktest-basic
menu permalinktest-basic
meter permalinkbasic-test
number-field permalinkbasic-test
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker-button permalinkbasic-test
picker permalinkbasic-test
popover permalinktest-basic
progress-bar permalinkbasic-test
progress-circle permalinkbasic-test
radio permalinktest-basic
search permalinktest-basic
sidenav permalinktest-basic
slider permalinktest-basic
split-view permalinkbasic-test
swatch permalinkbasic-test
switch permalinktest-basic
table permalinkbasic-test
tabs permalinkbasic-test
tags permalinkbasic-test
textfield permalinktest-basic
thumbnail permalinkbasic-test
toast permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
top-nav permalinkbasic-test
tray permalinkbasic-test
truncated permalinkbasic-test
underlay permalinkbasic-test
Firefoxaccordion permalinkbasic-test
action-bar permalinkbasic-test
action-button permalinkbasic-test
action-group permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
alert-banner permalinkbasic-test
alert-dialog permalinkbasic-test
asset permalinkbasic-test
avatar permalinktest-basic
badge permalinkbasic-test
breadcrumbs permalinkbasic-test
button-group permalinkbasic-test
button permalinktest-basic
card permalinktest-basic
checkbox permalinktest-basic
coachmark permalinkbasic-test
color-area permalinkbasic-test
color-field permalinkbasic-test
color-handle permalinkbasic-test
color-loupe permalinkbasic-test
color-slider permalinkbasic-test
color-wheel permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
contextual-help permalinkbasic-test
dialog permalinkbasic-test
divider permalinkbasic-test
dropzone permalinktest-basic
field-group permalinkbasic-test
field-label permalinkbasic-test
grid permalinkbasic-test
help-text permalinkbasic-test
icon permalinktest-basic
icons permalinktest-basic
illustrated-message permalinktest-basic
infield-button permalinkbasic-test
link permalinktest-basic
menu permalinktest-basic
meter permalinkbasic-test
number-field permalinkbasic-test
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker-button permalinkbasic-test
picker permalinkbasic-test
popover permalinktest-basic
progress-bar permalinkbasic-test
progress-circle permalinkbasic-test
radio permalinktest-basic
search permalinktest-basic
sidenav permalinktest-basic
slider permalinktest-basic
split-view permalinkbasic-test
swatch permalinkbasic-test
switch permalinktest-basic
table permalinkbasic-test
tabs permalinkbasic-test
tags permalinkbasic-test
textfield permalinktest-basic
thumbnail permalinkbasic-test
toast permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
top-nav permalinkbasic-test
tray permalinkbasic-test
truncated permalinkbasic-test
underlay permalinkbasic-test
|
TarunAdobe
reviewed
Sep 18, 2024
There was a problem hiding this comment.
This is great! I have a question though. This does update the theme attribute to system in most of the places except for few of our internal testing/tooling workflow files like documentation-site, web-test-runner.utils.js etc. We'd probably want to update those for consistency purposes at some point of time too if not in this pr right?
Rajdeepc
requested changes
Sep 18, 2024
| @@ -476,11 +440,6 @@ function checkForIssues( | |||
| } | |||
| }; | |||
|
|
|||
| if (hasThemeAttribute) { | |||
There was a problem hiding this comment.
Should we keep till all the downstream consumers has migrated to system? Just a thought
There was a problem hiding this comment.
I'd be for taking advantage of the opportunity and clean it altogether. We are not doing this for any other deprecation removal in our system. Let me know what you think.
| @@ -199,53 +199,4 @@ describe('Setting attributes', () => { | |||
| ).to.equal(3); | |||
| } | |||
| }); | |||
|
|
|||
| it('prefers system over theme', async () => { | |||
There was a problem hiding this comment.
We are removing the respective functionality, so there may not be anything left to test here. Please let me know if I’ve misunderstood your comment!
There was a problem hiding this comment.
Added a test for system!
rubencarvalho
added
1.0.0
I have now updated all instances of |
Rajdeepc
requested changes
Oct 16, 2024
blunteshwar
reviewed
Oct 17, 2024
| @@ -243,7 +243,6 @@ jobs: | |||
| keys: | |||
| - v2-golden-images-<< pipeline.parameters.current_golden_images_hash >>-hcm- | |||
| - v2-golden-images-main-hcm- | |||
| - v2-golden-images-main-spectrum-lightest-medium-ltr- | |||
There was a problem hiding this comment.
Why did we remove it?
There was a problem hiding this comment.
We removed the lightest tests, so they are no longer part of our test suite. As a result, we will not be regenerating the v2-golden-images-main-spectrum-lightest-medium-ltr- cache key. While we could change it to light, these are fallback cache keys and are in order. The first two should be sufficient. These caches stay-alive time is 15 days on CircleCI.
Rajdeepc
approved these changes
Oct 17, 2024
rubencarvalho
merged commit 4ce09fa
into
ruben/remove-deprecations
38 of 41 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the deprecated
themeattribute in thesp-themecomponent, along with all associated references and dependencies.Related issue(s)
Motivation and context
For the upcoming 1.0.0 release of Spectrum Web Components, we will remove the deprecated components and features.
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.