You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to some spottiness and difficulty throughout the team debugging CircleCI, this pull request migrations a few low-impact tasks to GitHub Actions using a format that is already validated to be working in Spectrum CSS.
Move linting from CircleCI to being run and tracked via GitHub Actions
Add CI caching support via a key: OS + node version + yarn lockfile hash
leveraging these local caches has been shown to speed up CI runs significantly
New build workflow to validate the build steps continue to work in all supported development environments: MacOS, Linux, and Windows. This also ensures no uncommitted changes arise from the build task.
A single pull-request entry-point development.yml that runs on pull requests and pushes. It validates the build in each supported env, checks test coverage, and runs linting.
A new lint workflow built off the linting previous done in CircleCI plus the tooling leveraged current in the Spectrum CSS project.
How has this been tested?
Setup:
Create a fork branch off this one: git checkout -b test-circleci-migration
Commit this update without verifying (it will get blocked in precommit checks otherwise and we want to validate the reviewdog task): git commit --no-verify -m "break styles"
Validate eslint plugin
Update packages/accordion/src/Accordion.ts with import { css, CSSResultArray, html, PropertyValues, SizedMixin, SpectrumElement, TemplateResult, } from '@spectrum-web-components/base';
Commit this update without verifying (it will get blocked in precommit checks otherwise and we want to validate the reviewdog task): git commit --no-verify -m "break typescript"
To validate the above, open a pull request for the test branch update against main and let CI do its thing.
Expect a comment to be added to the pull request reporting the errors in this update
Types of changes
Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)
If my change required a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.
castastrophe
changed the title
chore: migrate lint from circleci to github actions [SWC-767]
chore: migrate workflows from circleci to github actions [SWC-767]
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component:ToolingIssue or PR dealing with scripts, workflows, automation, etc. Component prefix is for Jiragithub_actionsPull requests that update GitHub Actions code
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to some spottiness and difficulty throughout the team debugging CircleCI, this pull request migrations a few low-impact tasks to GitHub Actions using a format that is already validated to be working in Spectrum CSS.
and Windows. This also ensures no uncommitted changes arise from the build task.development.ymlthat runs on pull requests and pushes. It validates the build in each supported env, checks test coverage, and runs linting.How has this been tested?
Setup:
Create a fork branch off this one:
git checkout -b test-circleci-migrationValidate stylelint plugin
packages/accordion/src/accordion.csswith:host { --spectrum-logical-rotation: ; --spectrum-logical-rotation: ; }(duplicate variable intentional)git commit --no-verify -m "break styles"Validate eslint plugin
packages/accordion/src/Accordion.tswithimport { css, CSSResultArray, html, PropertyValues, SizedMixin, SpectrumElement, TemplateResult, } from '@spectrum-web-components/base';git commit --no-verify -m "break typescript"To validate the above, open a pull request for the test branch update against main and let CI do its thing.
Expect a comment to be added to the pull request reporting the errors in this update
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.