feat(illustrated-message) - new size and orientation API#6155
feat(illustrated-message) - new size and orientation API#6155miwha-adobe wants to merge 9 commits intos2/illustrated-messagefrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… heading Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ctrum-web-components into miwha/swc-1835-illustrated-message-additive
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Rajdeepc
left a comment
There was a problem hiding this comment.
Looking good. If you can tests for attribute <-> property checks for size and orientation for optionally invalid values with warnings that would be great.
2nd-gen/packages/core/components/illustrated-message/IllustratedMessage.types.ts
Outdated
Show resolved
Hide resolved
2nd-gen/packages/core/components/illustrated-message/IllustratedMessage.base.ts
Show resolved
Hide resolved
2nd-gen/packages/core/components/illustrated-message/IllustratedMessage.base.ts
Show resolved
Hide resolved
|
Description
Adds
sizeandorientationas additive properties toswc-illustrated-messageas part of the Spectrum 2 migration. Includes:ILLUSTRATED_MESSAGE_VALID_SIZESandILLUSTRATED_MESSAGE_VALID_ORIENTATIONSconstants and derived types inIllustratedMessage.types.tssize('s' | 'm' | 'l', default'm') andorientation('vertical' | 'horizontal', default'vertical') reflected properties onIllustratedMessageBaseMotivation and context
Spectrum 2 introduces t-shirt sizing and a horizontal layout variant for illustrated message. Full token-based styling will follow in SWC-1838.
Related issue(s)
Screenshots (if appropriate)
N/A — visual tokens not yet implemented (SWC-1838).
Author's checklist
Manual review test cases
Note: Storybook is not fully configured. Those changes will be covered in: https://jira.corp.adobe.com/browse/SWC-1841
sizeattribute reflects correctlyorientationattribute reflects correctlyAccessibility testing checklist
Keyboard — No interactive elements added; no keyboard behavior changes. Tab moves through any slotted actions in DOM order, which is unchanged by
orientation(CSS-only layout shift).Screen reader — No ARIA changes.
orientationaffects only visual layout, not DOM order, so reading order is unaffected.