Skip to content

feat(illustrated-message) - new size and orientation API#6155

Open
miwha-adobe wants to merge 9 commits intos2/illustrated-messagefrom
miwha/swc-1835-illustrated-message-additive
Open

feat(illustrated-message) - new size and orientation API#6155
miwha-adobe wants to merge 9 commits intos2/illustrated-messagefrom
miwha/swc-1835-illustrated-message-additive

Conversation

@miwha-adobe
Copy link
Copy Markdown

Description

Adds size and orientation as additive properties to swc-illustrated-message as part of the Spectrum 2 migration. Includes:

  • ILLUSTRATED_MESSAGE_VALID_SIZES and ILLUSTRATED_MESSAGE_VALID_ORIENTATIONS constants and derived types in IllustratedMessage.types.ts
  • size ('s' | 'm' | 'l', default 'm') and orientation ('vertical' | 'horizontal', default 'vertical') reflected properties on IllustratedMessageBase
  • Structural CSS placeholder selectors for both attributes (full S2 token-based styles tracked in SWC-1838)

Motivation and context

Spectrum 2 introduces t-shirt sizing and a horizontal layout variant for illustrated message. Full token-based styling will follow in SWC-1838.

Related issue(s)

  • SWC-1835
  • SWC-1836
  • SWC-1837

Screenshots (if appropriate)

N/A — visual tokens not yet implemented (SWC-1838).

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Manual review test cases

Note: Storybook is not fully configured. Those changes will be covered in: https://jira.corp.adobe.com/browse/SWC-1841

  • size attribute reflects correctly

    1. Open illustrated message Storybook story
    2. Expect the attribute to be visible
  • orientation attribute reflects correctly

    1. Open illustrated message Storybook story
    2. Expect the attribute to be visible

Accessibility testing checklist

  • Keyboard — No interactive elements added; no keyboard behavior changes. Tab moves through any slotted actions in DOM order, which is unchanged by orientation (CSS-only layout shift).

  • Screen reader — No ARIA changes. orientation affects only visual layout, not DOM order, so reading order is unaffected.

@miwha-adobe miwha-adobe requested a review from a team as a code owner April 8, 2026 22:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6155

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@Rajdeepc Rajdeepc changed the title Illustrated Message - Additive size and orientation API update feat(illustrated-message) - new size and orientation API Apr 9, 2026
Copy link
Copy Markdown
Contributor

@Rajdeepc Rajdeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. If you can tests for attribute <-> property checks for size and orientation for optionally invalid values with warnings that would be great.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 9, 2026

⚠️ No Changeset found

Latest commit: 3a935a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@miwha-adobe miwha-adobe requested a review from Rajdeepc April 10, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants