docs(a11y): a11y migration docs with JIRA issues#6159
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
|
|
||
| --- | ||
|
|
||
| ## Known 1st-gen issues |
| <!-- Document title (editable) --> | ||
|
|
||
| # Divider accessibility migration analysis | ||
| # Illustrated message accessibility migration analysis |
There was a problem hiding this comment.
Comment: Is this meant to be illustrated message? The file path has divider in it. Seems like a mistake or am I not reading this correctly?
|
|
||
| - `heading-level` property (attribute `heading-level`): integers `2`–`6`, default `2`. The shadow tree renders exactly one `<h2>` … `<h6>` matching that value. Values outside `2`–`6` (including `1`) must be clamped or coerced to `2`–`6` (for example `1` → `2`), or rejected in types with a documented default—pick one policy and document it in Storybook. | ||
| - `heading` slot: accepts a `span` only (or equivalent documented phrasing: a single `span` wrapper as the slotted node). Do not allow slotted `<h1>`–`<h6>`; authors must not put heading elements in light DOM for this slot. Implementation may validate in dev and warn or ignore invalid slotted tags. | ||
| - Optional `heading` attribute: when used, its text is rendered as the title inside the shadow heading (alongside or instead of slot content per product rules—document the precedence if both exist). |
There was a problem hiding this comment.
Comment: As a note on this optional, I chatted with @5t3ph and since we are severing the dependency with 1st gen, we removed the fallback to heading attributes. Instead gen2 only uses slots. Open to discuss further though: #6150 (comment)
There was a problem hiding this comment.
Do you have the file where that happens in the PR? I did a search on "deprecated" and couldn't find the example.
But that's a good question! I don't know the answer. If there is a hard dependency cut off from 1st gen, then maybe not? What do y'all think @5t3ph @caseyisonit @rubencarvalho ?
| @@ -0,0 +1,148 @@ | |||
| <!-- Generated breadcrumbs - DO NOT EDIT --> | |||
|
|
|||
There was a problem hiding this comment.
I think claude must have did these backwards somehow. This file path is for illustrated message and has divider content. The path also looks a little funny below:
CONTRIBUTOR-DOCS / Project planning / Components / Illustrated Message / Divider accessibility migration analysis
miwha-adobe
left a comment
miwha-adobe
left a comment
There was a problem hiding this comment.
Seems like maybe there was a mixup in the doc path / content between Illustrated Message and Divider
2 participants
Description
Motivation and context
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Device review
Accessibility testing checklist
Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).
Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.
Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.