Skip to content

fix(coachmark): make step count separator configurable for localization#6166

Closed
tmchow wants to merge 1 commit intoadobe:mainfrom
tmchow:osc/4780-coachmark-localize
Closed

fix(coachmark): make step count separator configurable for localization#6166
tmchow wants to merge 1 commit intoadobe:mainfrom
tmchow:osc/4780-coachmark-localize

Conversation

@tmchow
Copy link
Copy Markdown

@tmchow tmchow commented Apr 10, 2026

Description

The Coachmark component's step count (e.g., "1 of 3") had the "of" string hardcoded, preventing localization. This PR adds a step-count-of attribute (property: stepCountOf) that defaults to "of" and is used in the step count template.

Clients can now set step-count-of="von" for German or step-count-of="de" for Spanish without needing to use the step-count slot override. The existing slot override still works for full customization.

<sp-coachmark step-count-of="von" current-step="1" total-steps="3">
  ...
</sp-coachmark>

Fixes #4780


This contribution was developed with AI assistance (Claude Code).

Add step-count-of attribute (defaults to 'of') so clients can
localize the step count text (e.g. '1 of 3') without needing
to use the step-count slot override.

Fixes adobe#4780
@tmchow tmchow requested a review from a team as a code owner April 10, 2026 08:36
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 10, 2026

⚠️ No Changeset found

Latest commit: a2c0f68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tmchow tmchow closed this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Coachmark step count is not localized

1 participant