fix(coachmark): make step count separator configurable for localization#6166
Closed
tmchow wants to merge 1 commit intoadobe:mainfrom
Closed
fix(coachmark): make step count separator configurable for localization#6166tmchow wants to merge 1 commit intoadobe:mainfrom
tmchow wants to merge 1 commit intoadobe:mainfrom
Conversation
Add step-count-of attribute (defaults to 'of') so clients can localize the step count text (e.g. '1 of 3') without needing to use the step-count slot override. Fixes adobe#4780
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Coachmark component's step count (e.g., "1 of 3") had the "of" string hardcoded, preventing localization. This PR adds a
step-count-ofattribute (property:stepCountOf) that defaults to"of"and is used in the step count template.Clients can now set
step-count-of="von"for German orstep-count-of="de"for Spanish without needing to use thestep-countslot override. The existing slot override still works for full customization.Fixes #4780
This contribution was developed with AI assistance (Claude Code).