You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removes S1-only constants, types, and runtime guards from 2nd-gen core files now that 1st-gen packages no longer
depend on @spectrum-web-components/core.
StatusLight.types.ts: removes STATUSLIGHT_VARIANTS_SEMANTIC_S1, STATUSLIGHT_VARIANTS_COLOR_S1, STATUSLIGHT_VARIANTS_S1 and their corresponding types; simplifies type aliases to S2-only
ProgressCircle.types.ts: removes PROGRESS_CIRCLE_STATIC_COLORS_S1 and ProgressCircleStaticColorS1;
inlines values into the S2 constant
AlertBanner.types.ts: removes deprecated AlertBannerVariants backward-compat type
swc/Badge.ts: removes stale @todo comments on subtle and outline
Motivation and context
PR #6126 decoupled 1st-gen packages from @spectrum-web-components/core by inlining shared code locally. The
S1-specific exports in core were kept solely to support that cross-generation dependency, which no longer
exists.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes S1-only constants, types, and runtime guards from 2nd-gen core files now that 1st-gen packages no longer
depend on
@spectrum-web-components/core.Badge.types.ts: removesBADGE_VARIANTS_COLOR_S1,BADGE_VARIANTS_S1,BadgeColorVariantS1,BadgeVariantS1StatusLight.types.ts: removesSTATUSLIGHT_VARIANTS_SEMANTIC_S1,STATUSLIGHT_VARIANTS_COLOR_S1,STATUSLIGHT_VARIANTS_S1and their corresponding types; simplifies type aliases to S2-onlyProgressCircle.types.ts: removesPROGRESS_CIRCLE_STATIC_COLORS_S1andProgressCircleStaticColorS1;inlines values into the S2 constant
AlertBanner.types.ts: removes deprecatedAlertBannerVariantsbackward-compat typeStatusLight.base.ts: removes S1-onlydisabledattribute runtime warningswc/Badge.ts: removes stale@todocomments onsubtleandoutlineMotivation and context
PR #6126 decoupled 1st-gen packages from
@spectrum-web-components/coreby inlining shared code locally. TheS1-specific exports in core were kept solely to support that cross-generation dependency, which no longer
exists.
Related issue(s)
SWC-1885
Author's checklist
CONTRIBUTING and
PULL_REQUESTS documents.
Practices
Reviewer's checklist
Manual review test cases
yarn buildin2nd-gen/packages/coreDevice review
Accessibility testing checklist
Types and constants only — no component behavior or rendering changed. No accessibility testing required.