MWPW-174258: Metadata Tool #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonHowellSlavin
requested review from
Brandon32 and
meganthecoder
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Author
I was going to wait to update until code review was done since it requires updating the config to see it work on a page. |
Brandon32
reviewed
Nov 6, 2025
| }); | ||
|
|
||
| // Store original DA_SDK if it exists | ||
| originalSdk = window.DA_SDK; |
Brandon32
reviewed
Nov 6, 2025
| const init = async () => { | ||
| const mdForm = document.createElement('da-md-form'); | ||
| document.body.append(mdForm); | ||
| await delay(50); // Wait for connectedCallback and async operations |
Author
There was a problem hiding this comment.
They made the tests timeout. I believe the setTimeout works better here because the delay is to let lit finish rendering processes rather than wait for async operations to complete?
Brandon32
reviewed
Nov 6, 2025
Brandon32
approved these changes
Nov 6, 2025
meganthecoder
approved these changes
Nov 7, 2025
…selecting the correct index for select items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-174258
Test URLs: