Skip to content

Changing gnav height for standalone Gnav #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

Changing gnav height for standalone Gnav #3947

merged 1 commit into from
Apr 17, 2025

Conversation

bandana147
Copy link
Contributor

@bandana147 bandana147 commented Apr 10, 2025 •
edited by github-actions bot
Loading

  • As part of Spectrum's latest guidance, the gnav height has to be reduced to 56px for adobe home
  • Starting this with standalone Gnav

Resolves: MWPW-169766

Test URLs:

Standalone Gnav: https://adobecom.github.io/nav-consumer/navigation.html?env=stage&authoringpath=/federal/home&navbranch=gnav-compact&unav=appswitcher,profile,notifications,help

@bandana147 bandana147 added the needs-verification PR requires E2E testing by a reviewer label Apr 10, 2025
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Apr 10, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Apr 10, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bandana147 bandana147 changed the title Changing gnav height of standalone Gnav Changing gnav height for standalone Gnav Apr 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

@spadmasa
Copy link

Validation done on the pr
https://adobecom.github.io/nav-consumer/navigation.html?env=stage&authoringpath=/federal/home&navbranch=gnav-compact&unav=appswitcher,profile,notifications,help
image
image
image
image

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Apr 17, 2025
@milo-pr-merge milo-pr-merge bot merged commit b8e8640 into stage Apr 17, 2025
25 checks passed
@milo-pr-merge milo-pr-merge bot deleted the gnav-compact branch April 17, 2025 09:18
@milo-pr-merge milo-pr-merge bot mentioned this pull request Apr 17, 2025
Merged
nishantka pushed a commit to nishantka/milo that referenced this pull request Apr 21, 2025
@bandana147 @nishantka
Changing gnav height for standalone Gnav (adobecom#3947)
2c67957 
Changing gnav height of standalone
colloyd pushed a commit to colloyd/milo that referenced this pull request Apr 21, 2025
@bandana147 @colloyd
Changing gnav height for standalone Gnav (adobecom#3947)
c805389 
Changing gnav height of standalone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deva309 Deva309 Deva309 approved these changes

@sharmrj sharmrj sharmrj approved these changes

@sonawanesnehal3 sonawanesnehal3 sonawanesnehal3 approved these changes

@salonijain3 salonijain3 Awaiting requested review from salonijain3

@nishantka nishantka Awaiting requested review from nishantka

Assignees

@spadmasa spadmasa

@prativas22 prativas22

Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bandana147 @spadmasa @Deva309 @sharmrj @sonawanesnehal3 @prativas22