Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add x-request-id to the response #96

Merged

Conversation

dmartel
Copy link
Contributor

@dmartel dmartel commented Nov 27, 2024

πŸ”— Linked issue

#93

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add X-Request-Id to the response headers.
If the orignal request has the header or generateRequestId is set to true, the response will contains the X-Request-Id header.
Resolves #93

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage thetutlage merged commit e1da87e into adonisjs:7.x Nov 28, 2024
7 checks passed
@thetutlage
Copy link
Member

Thanks πŸ‘

@dmarko484
Copy link

Thank you ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequestId is not inclkuded in response header
3 participants