fix(validation/bigint): cast bigint like string to bigint

adonisjs · Nov 16, 2023 · 792dcd2 · 792dcd2
1 parent d51a7d3
commit 792dcd2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 22 deletions.
diff --git a/src/Validations/primitives/bigint.ts b/src/Validations/primitives/bigint.ts
@@ -36,20 +36,15 @@ export const bigint: SyncValidation = {
      * Attempt to cast bigint like string to a bigint. In case of
      * failure report the validation error
      */
-    const castedValue = Number(value)
-    if (isNaN(castedValue)) {
-      errorReporter.report(pointer, RULE_NAME, DEFAULT_MESSAGE, arrayExpressionPointer)
-      return
-    }
+    try {
+      const castedValue = BigInt(value)
 
-    if (castedValue === Infinity || castedValue === -Infinity) {
+      /**
+       * Mutate the value
+       */
+      mutate(castedValue)
+    } catch (e) {
       errorReporter.report(pointer, RULE_NAME, DEFAULT_MESSAGE, arrayExpressionPointer)
-      return
     }
-
-    /**
-     * Mutate the value
-     */
-    mutate(castedValue)
   },
 }
diff --git a/test/validations/bigint.spec.ts b/test/validations/bigint.spec.ts
@@ -21,7 +21,7 @@ function compile() {
 test.group('BigInt', () => {
   validate(bigint, test, 'helloworld', 10n, compile())
 
-  test('report error when value is near Infinity', ({ assert }) => {
+  test('work fine when value is near Infinity', ({ assert }) => {
     const reporter = new ApiErrorReporter(new MessagesBag({}), false)
     bigint.validate(
       '-3177777777777777777777777777777777777777777777777777777777777777777777777770000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000009999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999991111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111',
@@ -37,15 +37,7 @@ test.group('BigInt', () => {
       }
     )
 
-    assert.deepEqual(reporter.toJSON(), {
-      errors: [
-        {
-          field: 'age',
-          rule: 'bigint',
-          message: 'bigint validation failed',
-        },
-      ],
-    })
+    assert.deepEqual(reporter.toJSON(), { errors: [] })
   })
 
   test('report error when value is not a valid bigint', ({ assert }) => {