-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(date)!: Restore 'format', 'precison', and usage of moment
for the date validator
#726
base: main
Are you sure you want to change the base?
fix(date)!: Restore 'format', 'precison', and usage of moment
for the date validator
#726
Commits on Oct 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for df8daac - Browse repository at this point
Copy the full SHA df8daacView commit details -
test: restore moment-based tests of date validator
- add explicit test for "wrongDateFormat" being raised when options.format is given and not satisfied
Configuration menu - View commit details
-
Copy full SHA for f8e5337 - Browse repository at this point
Copy the full SHA f8e5337View commit details -
feat(date-validation): reimplement the date validator that was remove…
…d by ember-validators - the version from ember-validators does not support "now" or "precision" or "format" correctly, and is unlikely to change to support them - indicate that `moment` should be installed in the consuming application, but it does not need to be provided by this package - TODO: allow configuring the date library used, e.g. provide a moment validator, a luxon validator, etc, and allow the consuming applications to indicate which kind should be used.
Configuration menu - View commit details
-
Copy full SHA for 73f782d - Browse repository at this point
Copy the full SHA 73f782dView commit details -
test(date): add test for case when relationship value is not valid
(This can show up in debounced input scenarios, e.g. where a user is editing both a start and an end date.)
Configuration menu - View commit details
-
Copy full SHA for 27d78e0 - Browse repository at this point
Copy the full SHA 27d78e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f97807a - Browse repository at this point
Copy the full SHA f97807aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e04230 - Browse repository at this point
Copy the full SHA 8e04230View commit details
Commits on Oct 16, 2022
-
refactor: revert changes to "date" validator
- move new code to "date-moment" validator - TODO: ensure moment is actually optional - TODO: same approach for luxon
Configuration menu - View commit details
-
Copy full SHA for 0440ba0 - Browse repository at this point
Copy the full SHA 0440ba0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8a4c00 - Browse repository at this point
Copy the full SHA f8a4c00View commit details
Commits on Oct 18, 2022
-
docs: begin updating the "upgrading" docs
Ideally we could just link to ember-validators, but they do not offer upgrading guidance - Some examples need to be fleshed out further
Configuration menu - View commit details
-
Copy full SHA for 1350f66 - Browse repository at this point
Copy the full SHA 1350f66View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0e7883 - Browse repository at this point
Copy the full SHA a0e7883View commit details
Commits on Oct 21, 2022
-
since optionalDependencies will be attempted for install
Configuration menu - View commit details
-
Copy full SHA for 65ca96f - Browse repository at this point
Copy the full SHA 65ca96fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 666dbaf - Browse repository at this point
Copy the full SHA 666dbafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e9b95a - Browse repository at this point
Copy the full SHA 5e9b95aView commit details