Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date)!: Restore 'format', 'precison', and usage of moment for the date validator #726

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Commits on Oct 8, 2022

  1. Configuration menu
    Copy the full SHA
    df8daac View commit details
    Browse the repository at this point in the history
  2. test: restore moment-based tests of date validator

     - add explicit test for "wrongDateFormat" being raised when options.format is given and not satisfied
    tehhowch committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    f8e5337 View commit details
    Browse the repository at this point in the history
  3. feat(date-validation): reimplement the date validator that was remove…

    …d by ember-validators
    
     - the version from ember-validators does not support "now" or "precision" or "format" correctly, and is unlikely to change to support them
     - indicate that `moment` should be installed in the consuming application, but it does not need to be provided by this package
       - TODO: allow configuring the date library used, e.g. provide a moment validator, a luxon validator, etc, and allow the consuming applications to indicate which kind should be used.
    tehhowch committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    73f782d View commit details
    Browse the repository at this point in the history
  4. test(date): add test for case when relationship value is not valid

    (This can show up in debounced input scenarios, e.g. where a user is editing both a start and an end date.)
    tehhowch committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    27d78e0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f97807a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8e04230 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2022

  1. refactor: revert changes to "date" validator

     - move new code to "date-moment" validator
     - TODO: ensure moment is actually optional
     - TODO: same approach for luxon
    tehhowch committed Oct 16, 2022
    Configuration menu
    Copy the full SHA
    0440ba0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f8a4c00 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. docs: begin updating the "upgrading" docs

    Ideally we could just link to ember-validators, but they do not offer upgrading guidance
    
     - Some examples need to be fleshed out further
    tehhowch committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    1350f66 View commit details
    Browse the repository at this point in the history
  2. chore: native class syntax

    tehhowch committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    a0e7883 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. chore: use peerDependencies

    since optionalDependencies will be attempted for install
    tehhowch committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    65ca96f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    666dbaf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5e9b95a View commit details
    Browse the repository at this point in the history