Refactor ember-data feature detection #737
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsmanuel
force-pushed
the
ember-data-deprecations
branch
from
6f4d32d
to
3ecd1eb
Compare
fsmanuel
changed the title
fsmanuel
force-pushed
the
update-ember-cli-to-4-12
branch
from
0599dff
to
40f65b6
Compare
We don’t change the package node requirements so it’s not a breaking change but to test against ember-data v4.12 we need node v16.
Instead of the DS.PromiseObject and DS.PromiseArray we now test against a real ember data model. Both `sync` and `async` behaviors are covered now.
Instead of checking if DS exists, we now check if `Model` from `@ember-data/model` is present.
fsmanuel
force-pushed
the
ember-data-deprecations
branch
from
3ecd1eb
to
67c14b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.